Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the re-encryption loading screen appear before the re-encryption starts #10352

Closed
jrainville opened this issue Apr 18, 2023 · 4 comments · Fixed by #10355 or #10397
Closed

Make the re-encryption loading screen appear before the re-encryption starts #10352

jrainville opened this issue Apr 18, 2023 · 4 comments · Fixed by #10355 or #10397
Assignees
Milestone

Comments

@jrainville
Copy link
Member

Description

Right now, the re-encryption starts and the loading screen with the message to not shut down the app appears after the re-encryption starts. So on slower machines, the re-encryption freezes the app, and the loading screen never appears. They then close the app, thinking it it broken, not knowing that by doing that, they actually broke it.

The fix here is to make sure the loading screen appear before we start the re-encryption.

@jrainville jrainville added this to the 0.11.1 milestone Apr 18, 2023
@jrainville jrainville self-assigned this Apr 18, 2023
jrainville added a commit that referenced this issue Apr 18, 2023
Fixes #10352

Adds a 1 second timer before re-encrypting, to make sure the loading screen is shown before it starts, since it can freeze.
@jrainville jrainville moved this to Code review in Status Desktop/Mobile Board Apr 18, 2023
@jrainville
Copy link
Member Author

Seems like there is an actual problem in Windows. It really does fail even before trying to re-encrypt.

I have deja-vu with that error:

ReEncryptKeyStoreDir error: unable to rename keyDirPath to backupKeyDirPath: rename C:\Users\sur_e\AppData\Local\Status\data\keystore\0x438551f7a44bcd9e3d32bf8c734fabb19d56dc8cd798a52b0e6d11b52e\ C:\Users\sur_e\AppData\Local\Status\data\keystore\0x438551f7a44bcd9e3d32bf8c734fabb19d56dc8c860435d798a52b0e6d11b52e\-backup: The process cannot access the ecause it is being used by another process

@alaibe do you remember?

I confirmed that there is no other process.

@alaibe
Copy link
Collaborator

alaibe commented Apr 19, 2023

@jrainville i don't remember this. I only remember the length of the path being too long but that doesn't seem to be same error

Could it be the app sleeping?

@jrainville
Copy link
Member Author

I found the issue. It was a path issue. See how the path has a slash at the end.
Fixed here status-im/status-go#3411

jrainville added a commit that referenced this issue Apr 21, 2023
Fixes #10352

Adds a 1 second timer before re-encrypting, to make sure the loading screen is shown before it starts, since it can freeze.
jrainville added a commit that referenced this issue Apr 21, 2023
Fixes #10352

Adds a 1 second timer before re-encrypting, to make sure the loading screen is shown before it starts, since it can freeze.
@jrainville
Copy link
Member Author

Completed here #10355

@github-project-automation github-project-automation bot moved this from Code review to Done in Status Desktop/Mobile Board Apr 21, 2023
jrainville added a commit that referenced this issue Apr 24, 2023
Fixes #10352

Adds a 1 second timer before re-encrypting, to make sure the loading screen is shown before it starts, since it can freeze.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment