fix(re-encryption): make sure loading screen is shown when re-encrypting #10355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #10352 Adds a 1 second timer before re-encrypting, to make sure the loading screen is shown before it starts, since it can freeze.
jrainville
requested review from
a team,
0x-r4bbit,
richard-ramos,
alaibe,
borismelnik and
saledjenic
and removed request for
a team,
0x-r4bbit and
richard-ramos
Jenkins BuildsClick to see older builds (7)
|
|
I found an actual issue on Windows with the re-encryption. This PR is still nice, but it doesn't fix the issue completely for Windows |
alaibe
approved these changes
Apr 19, 2023
saledjenic
approved these changes
Apr 19, 2023
There was a problem hiding this comment.
@anastasiyaig changes look good, but please test all login variants having 2 set up accounts and switch them.
|
I found the actual bug. It is fixed here in status-go: status-im/status-go#3411 I created a release branch on status-go, since we plan on creating a patch. Waiting for the merge to update and point to the release branch |
jrainville
force-pushed
the
fix/loading-screen-re-encryption
branch
from
a084ba2
to
28704b6
Compare
This was referenced Apr 21, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10352
Adds a 1 second timer before re-encrypting, to make sure the loading screen is shown before it starts, since it can freeze.
Do note that this is on top of the release branch. I'll cherry-pick on master once it is merged.
I have not tested with an actual big re-encryption yet, but I could reproduce the issue with a
sleepand the timer fixed the freeze.I'll test later on Windows.