Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wallet: Add a new account modal accepts invalid addresses #15779

Closed
micieslak opened this issue Jul 24, 2024 · 1 comment · Fixed by #15893
Closed

Wallet: Add a new account modal accepts invalid addresses #15779

micieslak opened this issue Jul 24, 2024 · 1 comment · Fixed by #15893
Assignees
@saledjenic
Labels
2-30-bug-bash bug Something isn't working
Milestone
2.30.0 Beta

Comments

@micieslak
Copy link
Member

Bug Report

Description

It's possible to add address with invalid check sum via Add a new account modal.

Screencast.from.24.07.2024.17.52.52.webm
@micieslak micieslak added bug Something isn't working 2-30-bug-bash labels Jul 24, 2024
@iurimatias iurimatias added this to the 2.30.0 Beta milestone Jul 26, 2024
@saledjenic saledjenic self-assigned this Jul 29, 2024
@saledjenic
Copy link
Contributor

Explained here #15772 (comment) there is no invalid address.

saledjenic added a commit that referenced this issue Jul 30, 2024
@saledjenic
feat: checksum validation added to adding watch only address
51c0cf0 
Fixes: #15779
@saledjenic saledjenic moved this to In Progress in Status Desktop/Mobile Board Jul 30, 2024
@saledjenic saledjenic mentioned this issue Jul 30, 2024
Merged
@saledjenic saledjenic moved this from In Progress to Code Review in Status Desktop/Mobile Board Jul 30, 2024
saledjenic added a commit that referenced this issue Jul 30, 2024
@saledjenic
feat: checksum validation added to adding watch only address
c86b07a 
Fixes: #15779
saledjenic added a commit that referenced this issue Jul 30, 2024
@saledjenic
feat: checksum validation added to adding watch only address
2f654a3 
Fixes: #15779
@github-project-automation github-project-automation bot moved this from Code Review to Done in Status Desktop/Mobile Board Jul 30, 2024
saledjenic added a commit that referenced this issue Jul 31, 2024
@saledjenic
feat: checksum validation added to adding watch only address
361b71a 
Fixes: #15779
saledjenic added a commit that referenced this issue Jul 31, 2024
@saledjenic
feat: checksum validation added to adding watch only address
ab63193 
Fixes: #15779
saledjenic added a commit that referenced this issue Aug 9, 2024
@saledjenic
feat: checksum validation added to adding watch only address
3eb6fa2 
Fixes: #15779
jrainville pushed a commit that referenced this issue Aug 9, 2024
@saledjenic @jrainville
feat: checksum validation added to adding watch only address
9caf23d 
Fixes: #15779
saledjenic added a commit that referenced this issue Aug 12, 2024
@saledjenic
feat: checksum validation added to adding watch only address
046d505 
Fixes: #15779
jrainville pushed a commit that referenced this issue Aug 12, 2024
@saledjenic
fix: checksum validation (#15915)
7dc0873 
* feat: checksum validation added to adding saved addresses

Fixes: #15772

* feat: checksum validation added to adding watch only address

Fixes: #15779
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@saledjenic saledjenic

Labels
2-30-bug-bash bug Something isn't working
Projects
Status Desktop/Mobile Board
Archived in project
Milestone
2.30.0 Beta
4 participants
@iurimatias @caybro @micieslak @saledjenic