Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: checksum validation added when adding saved address and watch only address #15893

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

saledjenic
Copy link
Contributor

@status-im-auto
Copy link
Member

status-im-auto commented Jul 30, 2024

Jenkins Builds

Click to see older builds (7)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 51c0cf0 #1 2024-07-30 13:33:58 ~6 min tests/nim 📄log
✔️ 51c0cf0 #1 2024-07-30 13:37:22 ~9 min macos/aarch64 🍎dmg
✔️ 51c0cf0 #1 2024-07-30 13:38:49 ~11 min macos/x86_64 🍎dmg
✔️ 51c0cf0 #1 2024-07-30 13:40:57 ~13 min tests/ui 📄log
✔️ 51c0cf0 #1 2024-07-30 13:42:11 ~14 min linux-nix/x86_64 📦tgz
✔️ 51c0cf0 #1 2024-07-30 13:44:08 ~16 min linux/x86_64 📦tgz
✔️ 51c0cf0 #1 2024-07-30 13:53:05 ~25 min windows/x86_64 💿exe
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ c86b07a #2 2024-07-30 14:59:48 ~6 min tests/nim 📄log
✔️ c86b07a #2 2024-07-30 15:00:52 ~7 min macos/x86_64 🍎dmg
✔️ c86b07a #2 2024-07-30 15:04:25 ~11 min macos/aarch64 🍎dmg
✔️ c86b07a #2 2024-07-30 15:04:56 ~12 min linux-nix/x86_64 📦tgz
✔️ c86b07a #2 2024-07-30 15:07:03 ~14 min tests/ui 📄log
✔️ c86b07a #2 2024-07-30 15:09:00 ~16 min linux/x86_64 📦tgz
✔️ c86b07a #2 2024-07-30 15:25:59 ~32 min windows/x86_64 💿exe
✔️ 2f654a3 #3 2024-07-30 15:47:19 ~6 min macos/aarch64 🍎dmg
✔️ 2f654a3 #3 2024-07-30 15:47:28 ~6 min tests/nim 📄log
✔️ 2f654a3 #3 2024-07-30 15:49:17 ~8 min macos/x86_64 🍎dmg
✔️ 2f654a3 #3 2024-07-30 15:54:32 ~13 min linux-nix/x86_64 📦tgz
✔️ 2f654a3 #3 2024-07-30 15:57:05 ~16 min linux/x86_64 📦tgz
2f654a3 #3 2024-07-30 15:57:08 ~16 min tests/ui 📄log
✔️ 2f654a3 #3 2024-07-30 16:10:46 ~29 min windows/x86_64 💿exe
✔️ 2f654a3 #4 2024-07-30 16:14:48 ~16 min tests/ui 📄log
✔️ 2f654a3 #5 2024-07-30 16:25:06 ~8 min tests/ui 📄log

Copy link
Member

@caybro caybro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

}

StatusToolTip {
visible: tooltipSensor.containsMouse
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
visible: tooltipSensor.containsMouse
visible: tooltipSensor.containsMouse && !!text

@status-im-auto
Copy link
Member

Copy link
Member

@micieslak micieslak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@saledjenic saledjenic merged commit fdd743a into master Jul 30, 2024
9 checks passed
@saledjenic saledjenic deleted the fix/checksum-validation branch July 30, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants