Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap "Approve" button becomes enabled before Approve Tx succeeds/fails #15784

Closed
dlipicar opened this issue Jul 24, 2024 · 0 comments · Fixed by #15807
Closed

Swap "Approve" button becomes enabled before Approve Tx succeeds/fails #15784

dlipicar opened this issue Jul 24, 2024 · 0 comments · Fixed by #15807
Assignees
Labels
2-30-bug-bash bug Something isn't working E:D Swap M1 Implement Swap operations swaps
Milestone

Comments

@dlipicar
Copy link
Contributor

Bug Report

Description

Screen.Recording.2024-07-24.at.13.30.19.mov

After triggering an Approve tx, the Approve button should remain in the loading state until the Tx succeeds/fails.
Ir now becomes re-enabled before that and eventually, due to auto-reload, turns into Swap.

Steps to reproduce

Set up a swap that requires an Approval until the Approve button becomes enabled. Then trigger the Approve tx. The "Approve" button goes into the "loading" state.

Expected behavior

The "Approve" button becomes enabled again after the Approve Tx succeeds, and it turns into the "Swap" button.

Actual behavior

The "Approve" button becomes enabled again before the Approve Tx succeeds, and it remains the "Approve" button.

Additional Information

  • Status desktop version: master c2a8817
  • Operating System: macOS Sonoma
@dlipicar dlipicar added bug Something isn't working swaps 2-30-bug-bash labels Jul 24, 2024
@dlipicar dlipicar added this to the 2.30.0 Beta milestone Jul 24, 2024
@Khushboo-dev-cpp Khushboo-dev-cpp self-assigned this Jul 24, 2024
Khushboo-dev-cpp added a commit that referenced this issue Jul 25, 2024
@Khushboo-dev-cpp Khushboo-dev-cpp moved this from In Progress to Code Review in Status Desktop/Mobile Board Jul 25, 2024
Khushboo-dev-cpp added a commit that referenced this issue Jul 25, 2024
@dlipicar dlipicar added the E:D Swap M1 Implement Swap operations label Jul 26, 2024
Khushboo-dev-cpp added a commit that referenced this issue Jul 29, 2024
@github-project-automation github-project-automation bot moved this from Code Review to Done in Status Desktop/Mobile Board Jul 29, 2024
Khushboo-dev-cpp added a commit that referenced this issue Jul 29, 2024
jrainville pushed a commit that referenced this issue Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2-30-bug-bash bug Something isn't working E:D Swap M1 Implement Swap operations swaps
Projects
Archived in project
2 participants