Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(@desktop/wallet): Swap "Approve" button becomes enabled before Approve Tx succeeds/fails #15858

Merged
merged 1 commit into from
Jul 29, 2024
Merged

fix(@desktop/wallet): Swap "Approve" button becomes enabled before Approve Tx succeeds/fails #15858

merged 1 commit into from
Jul 29, 2024

Conversation

Khushboo-dev-cpp
Copy link
Contributor

fixes #15784

master branch PR merged #15807

What does the PR do

Affected areas

StatusQ checklist

  • add documentation if necessary (new component, new feature)
  • update sandbox app
    • in case of new component, add new component page
    • in case of new features, add variation to existing component page
    • nice to have: add it to the demo application as well
  • test changes in both light and dark theme?

Screenshot of functionality (including design for comparison)

  • I've checked the design and this PR matches it

Cool Spaceship Picture

@Khushboo-dev-cpp Khushboo-dev-cpp requested review from caybro, dlipicar, alexjba, a team and virginiabalducci and removed request for a team July 29, 2024 12:41
@status-im-auto
Copy link
Member

status-im-auto commented Jul 29, 2024 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ d1c8264 #1 2024-07-29 12:48:35 ~6 min tests/nim 📄log
✔️ d1c8264 #1 2024-07-29 12:51:18 ~9 min macos/aarch64 🍎dmg
✔️ d1c8264 #1 2024-07-29 12:52:59 ~11 min macos/x86_64 🍎dmg
✔️ d1c8264 #1 2024-07-29 12:55:49 ~13 min tests/ui 📄log
✔️ d1c8264 #1 2024-07-29 12:57:07 ~15 min linux-nix/x86_64 📦tgz
✔️ d1c8264 #1 2024-07-29 12:58:15 ~16 min linux/x86_64 📦tgz
✔️ d1c8264 #1 2024-07-29 13:12:49 ~30 min windows/x86_64 💿exe

@virginiabalducci virginiabalducci mentioned this pull request Jul 29, 2024
Closed
virginiabalducci
virginiabalducci approved these changes Jul 29, 2024
View reviewed changes
Copy link

@virginiabalducci virginiabalducci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! QA passed

@jrainville jrainville merged commit 77addc0 into release/2.30.x Jul 29, 2024
9 checks passed
@jrainville jrainville deleted the fix/15784 branch July 29, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@virginiabalducci virginiabalducci virginiabalducci approved these changes

@alexjba alexjba alexjba approved these changes

@caybro caybro caybro approved these changes

@dlipicar dlipicar Awaiting requested review from dlipicar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Khushboo-dev-cpp @status-im-auto @caybro @alexjba @virginiabalducci @jrainville