Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat input: Cannot add mentions in the create chat view #8749

Closed
alexjba opened this issue Dec 12, 2022 · 8 comments · Fixed by #9018
Closed

Chat input: Cannot add mentions in the create chat view #8749

alexjba opened this issue Dec 12, 2022 · 8 comments · Fixed by #9018
Assignees
Labels
bug Something isn't working
Milestone

Comments

@alexjba
Copy link
Contributor

alexjba commented Dec 12, 2022

Description

Repro steps:
Create chat
Add some contacts
Write the first message with mention

Expected:
Mentions are available

Actual:
Cannot add mentions

Screen.Recording.2022-12-12.at.18.36.49.mov
@alexjba alexjba added bug Something isn't working ui labels Dec 12, 2022
@alexjba
Copy link
Contributor Author

alexjba commented Dec 12, 2022

Found in #7686

@alexandraB99
Copy link
Contributor

@benjthayer could you please add some input here, should mentions be present when creating a new 1-1 or group chat? (see video for details)

@benjthayer
Copy link

Hi @alexandraB99 it seems logical that they should be present - confirming with the design team - will get back to you asap

@John-44
Copy link

John-44 commented Jan 4, 2023

@alexandraB99 @benjthayer yes when creating an ad-hoc group chat, a user should be able to @ mention the members of the ad-hoc group chat that are present in the "To:" field.

@John-44
Copy link

John-44 commented Jan 4, 2023

@alexandraB99 @benjthayer also @ mentions don't need to be present in 1-1 chats, because every message in a 1-1 chat is an @ mention

@iurimatias iurimatias added this to the 0.9.0 RC milestone Jan 5, 2023
@alexandraB99
Copy link
Contributor

@benjthayer @John-44 but even before the group is actually created? so before the "Confirm" button is pressed to actually create the group? in the video if you notice, it's before creating the group, so does is make sense to mention someone in a group that is not yet created?

@benjthayer
Copy link

That is an interesting point. If the user is mentioned then subsequently removed from the final group members they will not receive the message or associated mention notification.

However, that feels like an edge case as in most cases a user mentioned in the initial message of a group chat will also be added to the initial member list.

Although there is a chance the user may accidentally delete the user from the group membership when they have mentioned them, it feels like worse UX to remove an expected feature like the mention suggestions.

What do you think @John-44 ?

@jrainville jrainville added messenger and removed ui labels Jan 9, 2023
@jrainville
Copy link
Member

I agree with @benjthayer and @John-44 that we should be able to mention the contacts we selected for the group even if confirm was not clicked.

Even if one of the contacts is removed and we mentioned them, it will not actually mention that person, since they will not be added. The name will be blue, but there will be no notification, so it's not a big deal.

This is more of a messenger issue, I'll take it.

@jrainville jrainville self-assigned this Jan 9, 2023
@jrainville jrainville moved this to In Progress in Status Desktop/Mobile Board Jan 9, 2023
jrainville added a commit that referenced this issue Jan 9, 2023
Fixes #8749

I couldn't fully test it because it needs #8991 to be fixed to see if the message is sent correctly
jrainville added a commit that referenced this issue Jan 9, 2023
Fixes #8749

I couldn't fully test it because it needs #8991 to be fixed to see if the message is sent correctly
@jrainville jrainville moved this from In Progress to Code review in Status Desktop/Mobile Board Jan 9, 2023
jrainville added a commit that referenced this issue Jan 10, 2023
Fixes #8749

I couldn't fully test it because it needs #8991 to be fixed to see if the message is sent correctly
jrainville added a commit that referenced this issue Jan 10, 2023
Fixes #8749

I couldn't fully test it because it needs #8991 to be fixed to see if the message is sent correctly
@github-project-automation github-project-automation bot moved this from Code review to Done in Status Desktop/Mobile Board Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

7 participants