fix(CreateChatView): enable mentioning people selected in create chat #9018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrainville
requested review from
a team,
IvanBelyakoff and
mprakhov
and removed request for
a team
Jenkins Builds
|
|
@jrainville Judging by the screenshot, the suggestion box does work with the selected people though. Your changes don't touch the username<->pubkey conversion, so I think this is good to go |
0x-r4bbit
approved these changes
Jan 10, 2023
mprakhov
approved these changes
Jan 10, 2023
jrainville
force-pushed
the
fix/mention-create-chat
branch
from
d586e85
to
6acd41a
Compare
|
I tested on top of Mykhailo's PR and sending the mention does work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8749
I couldn't fully test it because it needs #8991 to be fixed to see if the message is sent correctly