feature(connector)_: Add model join to handle connected dApps #15954

kounkou · 2024-08-01T09:32:03Z

What does the PR do

This PR contains the changes to be able to see the list of connected DApps on the Status desktop for Connector service. It also contains changes to managed DAppPermissionGranted and DAppPermissionRevoked

Affected areas

Connected DApps list

Screenshot of functionality (including design for comparison)

Screencast.from.2024-08-02.01-51-36.webm

Impact on end user

Similar to other PR's this PR reuses some Wallet connect functionalities. I performed test to make sure Wallet Connect still works as expected

How to test

Please refer to the video to test. Please be aware that this PR requires setting the FLAG_DAPPS_ENABLED flag to enabled since it enables seeing the list of DApps.

Or use : https://app.uniswap.org/swap

Risk

Very low risk since Connector service duplicated some WC facilities which live isolated and would not create regression by definition.

Tick one:

Low risk: 2 devs MUST perform testing as specified above and attach their results as comments to this PR before merging.
High risk: QA team MUST perform additional testing in the specified affected areas before merging.

status-im-auto · 2024-08-01T09:39:03Z

Jenkins Builds

Click to see older builds (32)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`ea38227`	#1	2024-08-01 09:39:02	~6 min	`tests/nim`	📄`log`
❌	`ea38227`	#1	2024-08-01 09:40:46	~8 min	`macos/x86_64`	📄`log`
❌	`ea38227`	#1	2024-08-01 09:42:40	~10 min	`linux-nix/x86_64`	📄`log`
❌	`ea38227`	#1	2024-08-01 09:43:30	~11 min	`macos/aarch64`	📄`log`
❌	`ea38227`	#1	2024-08-01 09:43:31	~11 min	`linux/x86_64`	📄`log`
❌	`ea38227`	#1	2024-08-01 09:44:39	~12 min	`tests/ui`	📄`log`
❌	`ea38227`	#1	2024-08-01 09:56:38	~24 min	`windows/x86_64`	📄`log`

✔️	`af8a916`	#3	2024-08-02 08:58:04	~7 min	`tests/nim`	📄`log`
✔️	`af8a916`	#3	2024-08-02 09:01:20	~10 min	`macos/aarch64`	🍎`dmg`
✔️	`af8a916`	#3	2024-08-02 09:01:52	~11 min	`macos/x86_64`	🍎`dmg`
❌	`af8a916`	#3	2024-08-02 09:02:32	~12 min	`tests/ui`	📄`log`
✔️	`af8a916`	#3	2024-08-02 09:06:37	~16 min	`linux-nix/x86_64`	📦`tgz`

✔️	`ad5242e`	#4	2024-08-02 09:13:22	~6 min	`tests/nim`	📄`log`
✔️	`ad5242e`	#4	2024-08-02 09:14:24	~7 min	`macos/aarch64`	🍎`dmg`
✔️	`ad5242e`	#4	2024-08-02 09:15:21	~8 min	`macos/x86_64`	🍎`dmg`

✔️	`e47fcaf`	#5	2024-08-02 09:23:25	~6 min	`tests/nim`	📄`log`
✔️	`e47fcaf`	#5	2024-08-02 09:23:41	~7 min	`macos/aarch64`	🍎`dmg`
✔️	`e47fcaf`	#5	2024-08-02 09:24:33	~7 min	`macos/x86_64`	🍎`dmg`
❌	`e47fcaf`	#5	2024-08-02 09:29:06	~12 min	`tests/ui`	📄`log`
✔️	`e47fcaf`	#5	2024-08-02 09:29:10	~12 min	`linux-nix/x86_64`	📦`tgz`
✔️	`e47fcaf`	#5	2024-08-02 09:32:29	~15 min	`linux/x86_64`	📦`tgz`
✔️	`e47fcaf`	#5	2024-08-02 09:44:54	~28 min	`windows/x86_64`	💿`exe`

✔️	`94e44d1`	#6	2024-08-02 18:52:13	~6 min	`tests/nim`	📄`log`
✔️	`94e44d1`	#6	2024-08-02 18:53:17	~7 min	`macos/aarch64`	🍎`dmg`
✔️	`94e44d1`	#6	2024-08-02 18:53:23	~7 min	`macos/x86_64`	🍎`dmg`

✔️	`58a90b9`	#7	2024-08-02 19:05:32	~6 min	`tests/nim`	📄`log`
✔️	`58a90b9`	#7	2024-08-02 19:05:49	~7 min	`macos/aarch64`	🍎`dmg`
✔️	`58a90b9`	#7	2024-08-02 19:06:27	~7 min	`macos/x86_64`	🍎`dmg`
✔️	`58a90b9`	#7	2024-08-02 19:12:02	~13 min	`tests/ui`	📄`log`
✔️	`58a90b9`	#7	2024-08-02 19:14:12	~15 min	`linux-nix/x86_64`	📦`tgz`
✔️	`58a90b9`	#7	2024-08-02 19:16:47	~18 min	`linux/x86_64`	📦`tgz`
✔️	`58a90b9`	#7	2024-08-02 19:24:19	~25 min	`windows/x86_64`	💿`exe`

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`5a51c2a`	#8	2024-08-06 18:32:27	~6 min	`tests/nim`	📄`log`
✔️	`5a51c2a`	#8	2024-08-06 18:33:41	~7 min	`macos/aarch64`	🍎`dmg`
✔️	`5a51c2a`	#8	2024-08-06 18:35:17	~9 min	`macos/x86_64`	🍎`dmg`
✔️	`5a51c2a`	#8	2024-08-06 18:38:41	~13 min	`linux-nix/x86_64`	📦`tgz`
✔️	`5a51c2a`	#8	2024-08-06 18:38:44	~12 min	`tests/ui`	📄`log`
✔️	`5a51c2a`	#8	2024-08-06 18:41:50	~16 min	`linux/x86_64`	📦`tgz`
✔️	`5a51c2a`	#8	2024-08-06 18:56:03	~30 min	`windows/x86_64`	💿`exe`

✔️	`e8ca7be`	#9	2024-08-06 19:53:44	~6 min	`tests/nim`	📄`log`
✔️	`e8ca7be`	#9	2024-08-06 19:55:01	~7 min	`macos/aarch64`	🍎`dmg`
✔️	`e8ca7be`	#9	2024-08-06 19:56:36	~9 min	`macos/x86_64`	🍎`dmg`
✔️	`e8ca7be`	#9	2024-08-06 20:00:32	~13 min	`tests/ui`	📄`log`
✔️	`e8ca7be`	#9	2024-08-06 20:00:32	~13 min	`linux-nix/x86_64`	📦`tgz`
✔️	`e8ca7be`	#9	2024-08-06 20:03:09	~16 min	`linux/x86_64`	📦`tgz`
✔️	`e8ca7be`	#9	2024-08-06 20:19:29	~32 min	`windows/x86_64`	💿`exe`

status-im-auto · 2024-08-02T08:58:11Z

✔️ status-desktop/prs/linux/x86_64/tests-nim/PR-15954#3 🔹 ~7 min 39 sec 🔹 `af8a916` 🔹 📦 tests/nim package

jrainville

Looks good

ui/app/AppLayouts/Wallet/services/dapps/DappsConnectorSDK.qml

status-im-auto · 2024-08-02T18:52:34Z

✔️ status-desktop/prs/linux/x86_64/tests-nim/PR-15954#6 🔹 ~6 min 59 sec 🔹 `94e44d1` 🔹 📦 tests/nim package

MishkaRogachev

Looks fine!

kounkou · 2024-08-06T18:31:42Z

Note for testers, and QA :

The current code is under a feature flag waiting for 1/ Status-go merge, 2/ QA testing. For those interested into testing the applicatio :

Download a build of the application Here
Activate the feature flag for testing the functionality :

export FLAG_DAPPS_ENABLED=1

Verify the needed functionality is activate

Perform the tests by referring to feature(connector)_: Add model join to handle connected dApps #15954 (comment) and the requirements in [Browser plugin connector] List browser plugin dApps in the dApps dialog #15885
If everything is as expected, please approve Enable dapps feature flag #15975 and merge.

kounkou · 2024-08-06T19:46:07Z

Performed testing again after merging status-go changes to make sure everything works as expected. Bumping status-go now.

kounkou · 2024-08-06T20:21:28Z

Hi @anastasiyaig could you be able to perform testing on this feature, instructions and information here : #15954 (comment) please 🙏🏾

* feature(connector)_: Add model join to handle connected dApps * Fix review comments * chore: bump status-go

felicio · 2024-08-07T14:16:08Z

My quick notes:

the video shows WalletConnect icon for the connector which is not WC
desktop crashes when left running for a while

#16006) * feature(connector)_: Add model join to handle connected dApps (#15954) * feature(connector)_: Add model join to handle connected dApps * Fix review comments * chore: bump status-go * chore: bump status-go to latest

felicio · 2024-08-07T22:59:54Z

Also, the component does not seem to be contextual. Meaning that if Account 1 (not All accounts) is elected, dApps for Account 2 can be disconnected.

kounkou · 2024-08-08T01:46:31Z

My quick notes:

the video shows WalletConnect icon for the connector which is not WC

Could you post a screenshot for this point, I am actually confused what you mean by shows WalletConnect icon for the connector which is not WC

desktop crashes when left running for a while

Do you have some more information about the crash? any logs to share please? Is it reproducible or it's just a one off? Also any estimation about the amount of time when saying for a while

kounkou · 2024-08-08T01:53:49Z

Also, the component does not seem to be contextual. Meaning that if Account 1 (not All accounts) is elected, dApps for Account 2 can be disconnected.

Thanks for bringing this is interesting perspective... 🙏🏾 If I understand what you meant here, the connections should obviously be filtered by account. I believe this should work unless there is a small tweak to make in the WC model fetching. @stefandunca do you confirm that this should work on WC or is there anything in progress?

felicio · 2024-08-08T01:55:11Z

Could you post a screenshot for this point, I am actually confused

kounkou · 2024-08-08T01:55:30Z

I am opening a new ticket, this PR is merged. let's move these on the other ticket

#16026

felicio · 2024-08-08T01:57:40Z

Do you have some more information about the crash?

On macOS, not logs to share atm. Try running it for more than ~1h, happens regularly.

stefandunca · 2024-08-09T08:15:12Z

Thanks for bringing this is interesting perspective... 🙏🏾 If I understand what you meant here, the connections should obviously be filtered by account. I believe this should work unless there is a small tweak to make in the WC model fetching. @stefandunca do you confirm that this should work on WC or is there anything in progress?

Indeed, it was implemented by @Seitseman here #15877

kounkou added backend-team E:D Browser Plugin Connector M1 Task to implement the connector between the browser plugin and Status labels Aug 1, 2024

kounkou self-assigned this Aug 1, 2024

kounkou force-pushed the feature-join-dappsModel-and-connector-models branch 2 times, most recently from 4ee6005 to af8a916 Compare August 2, 2024 08:50

kounkou force-pushed the feature-join-dappsModel-and-connector-models branch from af8a916 to ad5242e Compare August 2, 2024 09:06

kounkou marked this pull request as ready for review August 2, 2024 09:11

kounkou added the waiting-for-status-go-merge label Aug 2, 2024

kounkou requested review from MishkaRogachev, jrainville, stefandunca and felicio August 2, 2024 09:17

felicio mentioned this pull request Aug 2, 2024

feat_: connector revoke permissions and accounts status-im/status-go#5646

Merged

kounkou mentioned this pull request Aug 2, 2024

Enable dapps feature flag #15975

Open

jrainville approved these changes Aug 2, 2024

View reviewed changes

kounkou force-pushed the feature-join-dappsModel-and-connector-models branch from 94e44d1 to 58a90b9 Compare August 2, 2024 18:58

MishkaRogachev mentioned this pull request Aug 5, 2024

Release: connector response structure to valid json #15882

Merged

MishkaRogachev approved these changes Aug 5, 2024

View reviewed changes

iurimatias added this to the 2.30.0 Beta milestone Aug 6, 2024

kounkou added 2 commits August 6, 2024 14:25

feature(connector)_: Add model join to handle connected dApps

68c2671

Fix review comments

5a51c2a

jrainville force-pushed the feature-join-dappsModel-and-connector-models branch from 58a90b9 to 5a51c2a Compare August 6, 2024 18:25

chore: bump status-go

e8ca7be

kounkou merged commit bef6661 into master Aug 6, 2024
9 checks passed

kounkou deleted the feature-join-dappsModel-and-connector-models branch August 6, 2024 20:20

kounkou added a commit that referenced this pull request Aug 6, 2024

feature(connector)_: Add model join to handle connected dApps (#15954)

cdb6540

* feature(connector)_: Add model join to handle connected dApps * Fix review comments * chore: bump status-go

kounkou added a commit that referenced this pull request Aug 6, 2024

feature(connector)_: Add model join to handle connected dApps (#15954)

b4e07a5

* feature(connector)_: Add model join to handle connected dApps * Fix review comments * chore: bump status-go

kounkou mentioned this pull request Aug 6, 2024

feature(connector)_: Add model join to handle connected dApps (#15954) #16006

Merged

kounkou mentioned this pull request Aug 8, 2024

[Browser plugin connector] Follow-up fixes on Connected DApps display #16026

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feature(connector)_: Add model join to handle connected dApps #15954

feature(connector)_: Add model join to handle connected dApps #15954

kounkou commented Aug 1, 2024 •

edited by jrainville

Loading

status-im-auto commented Aug 1, 2024 •

edited

Loading

status-im-auto commented Aug 2, 2024

jrainville left a comment

status-im-auto commented Aug 2, 2024

MishkaRogachev left a comment

kounkou commented Aug 6, 2024 •

edited

Loading

kounkou commented Aug 6, 2024

kounkou commented Aug 6, 2024

felicio commented Aug 7, 2024

felicio commented Aug 7, 2024

kounkou commented Aug 8, 2024

kounkou commented Aug 8, 2024

felicio commented Aug 8, 2024

kounkou commented Aug 8, 2024 •

edited

Loading

felicio commented Aug 8, 2024

stefandunca commented Aug 9, 2024

feature(connector)_: Add model join to handle connected dApps #15954

feature(connector)_: Add model join to handle connected dApps #15954

Conversation

kounkou commented Aug 1, 2024 • edited by jrainville Loading

What does the PR do

Affected areas

Screenshot of functionality (including design for comparison)

Impact on end user

How to test

Risk

status-im-auto commented Aug 1, 2024 • edited Loading

Jenkins Builds

status-im-auto commented Aug 2, 2024

✔️ status-desktop/prs/linux/x86_64/tests-nim/PR-15954#3 🔹 ~7 min 39 sec 🔹 af8a916 🔹 📦 tests/nim package

jrainville left a comment

Choose a reason for hiding this comment

status-im-auto commented Aug 2, 2024

✔️ status-desktop/prs/linux/x86_64/tests-nim/PR-15954#6 🔹 ~6 min 59 sec 🔹 94e44d1 🔹 📦 tests/nim package

MishkaRogachev left a comment

Choose a reason for hiding this comment

kounkou commented Aug 6, 2024 • edited Loading

kounkou commented Aug 6, 2024

kounkou commented Aug 6, 2024

felicio commented Aug 7, 2024

felicio commented Aug 7, 2024

kounkou commented Aug 8, 2024

kounkou commented Aug 8, 2024

felicio commented Aug 8, 2024

kounkou commented Aug 8, 2024 • edited Loading

felicio commented Aug 8, 2024

stefandunca commented Aug 9, 2024

kounkou commented Aug 1, 2024 •

edited by jrainville

Loading

status-im-auto commented Aug 1, 2024 •

edited

Loading

✔️ status-desktop/prs/linux/x86_64/tests-nim/PR-15954#3 🔹 ~7 min 39 sec 🔹 `af8a916` 🔹 📦 tests/nim package

✔️ status-desktop/prs/linux/x86_64/tests-nim/PR-15954#6 🔹 ~6 min 59 sec 🔹 `94e44d1` 🔹 📦 tests/nim package

kounkou commented Aug 6, 2024 •

edited

Loading

kounkou commented Aug 8, 2024 •

edited

Loading