feature(connector)_: Add model join to handle connected dApps (#15954) #16006
Conversation
* feature(connector)_: Add model join to handle connected dApps * Fix review comments * chore: bump status-go
Jenkins Builds
|
|
Tested that everything still works as expected
|
kounkou
force-pushed
the
cherry-pick/15954
branch
from
59fb9f8
to
52b2d35
Compare
| import shared.stores 1.0 | ||
| import utils 1.0 | ||
|
|
||
| QObject { |
There was a problem hiding this comment.
I think this logic code should be part of the nim controller.
But I think it can be improved later.
There was a problem hiding this comment.
This is a quick win or low hanging fruit... based on conversation here. There will be a refactoring as part of 2.31...
If interested, you might need to discuss with stefandunca@ what would be the best approach to having an abstraction on top of Wallet Connect code that would streamline all this code.
|
The tests passed, only the report failed. I'll merge |
cherry-pick