Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore_: endpoint for checking address checksum validity added to wallet api #5629

Merged
merged 1 commit into from
Jul 30, 2024
Merged

chore_: endpoint for checking address checksum validity added to wallet api #5629

merged 1 commit into from
Jul 30, 2024

Conversation

saledjenic
Copy link
Contributor

@saledjenic saledjenic commented Jul 30, 2024 •
edited
Loading

  • added IsChecksumValidForAddress function to wallet api

@saledjenic saledjenic changed the title chore_: endpoint for checking address checksum validity added to wall… chore_: endpoint for checking address checksum validity added to wallet api Jul 30, 2024
@status-im-auto
Copy link
Member

✔️ status-go/prs/tests-rpc/PR-5629#1 🔹 ~2 min 36 sec 🔹 256c4c0 🔹 📦 tests-rpc package

@status-im-auto
Copy link
Member

status-im-auto commented Jul 30, 2024 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 256c4c0 #1 2024-07-30 13:23:28 ~2 min tests-rpc 📄log
✔️ 256c4c0 #1 2024-07-30 13:25:07 ~3 min linux 📦zip
✔️ 256c4c0 #1 2024-07-30 13:25:39 ~4 min ios 📦zip
✔️ 256c4c0 #1 2024-07-30 13:26:13 ~5 min android 📦aar
✔️ 256c4c0 #1 2024-07-30 14:07:02 ~45 min tests 📄log
✔️ 444dd70 #2 2024-07-30 14:53:07 ~2 min tests-rpc 📄log
✔️ 444dd70 #2 2024-07-30 14:53:30 ~3 min ios 📦zip
✔️ 444dd70 #2 2024-07-30 14:54:32 ~4 min linux 📦zip
✔️ 444dd70 #2 2024-07-30 14:55:50 ~5 min android 📦aar
✔️ 444dd70 #2 2024-07-30 15:35:47 ~45 min tests 📄log

@saledjenic saledjenic mentioned this pull request Jul 30, 2024
Merged
IvanBelyakoff
IvanBelyakoff approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@IvanBelyakoff IvanBelyakoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are enot using mobile enpoint for that right?

@saledjenic
chore_: endpoint for checking address checksum validity added to wall…
444dd70 
…et api

- added `IsChecksumValidForAddress` function to `wallet` api
@saledjenic saledjenic force-pushed the chore/add-valid-checksum-to-api branch from 256c4c0 to 444dd70 Compare July 30, 2024 14:50
@saledjenic
Copy link
Contributor Author

We are enot using mobile enpoint for that right?

At some point, I hope all those functions exposed via mobile/status.go will be removed

@saledjenic saledjenic merged commit 19b5bcf into develop Jul 30, 2024
10 checks passed
@saledjenic saledjenic deleted the chore/add-valid-checksum-to-api branch July 30, 2024 15:38
@saledjenic saledjenic mentioned this pull request Jul 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@belalshehab belalshehab belalshehab approved these changes

@IvanBelyakoff IvanBelyakoff IvanBelyakoff approved these changes

@ilmotta ilmotta Awaiting requested review from ilmotta

@alaibe alaibe Awaiting requested review from alaibe

@Cuteivist Cuteivist Awaiting requested review from Cuteivist

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@saledjenic @status-im-auto @IvanBelyakoff @belalshehab