-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: dial, drop and retrieve connected peers #5994
Conversation
- some minor progress to add nwaku in status-go - nwaku.go: GetNumConnectedPeers controls when passed pubsub is empty - waku_test.go: adapt TestWakuV2Store - add missing shard.go - feat_: build nwaku with nix and use build tags to choose between go-waku and nwaku (#5896) - chore_: update nwaku - nwaku bump (#5911) - bump: nwaku - chore: add USE_NWAKU env flag - fix: build libwaku only if needed - feat: testing discovery and dialing with nwaku integration (#5940)
…esult iterator impl (#5971)
…and libwaku test to run (#5986)
We require commits to follow the Conventional Commits, but with
|
Jenkins BuildsClick to see older builds (5)
|
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! just left some minor comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for it! 💯
e829dea
to
fd9d9f3
Compare
Closing this PR in favor of #6013 , as there are big conflicts with the base branch |
Integrating and implementing features to dial, drop and retrieve connected peers.
Important changes:
PeerCount()
functionsGetNumConnectedRelayPeers
This PR depends on the new libwaku procedures exposed in waku-org/nwaku#3149
Once the nwaku PR is merged, I will update the nwaku submodule in this PR
Issue: waku-org/nwaku#3076