Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dial, drop and retrieve connected peers #5994

Closed
wants to merge 14 commits into from

Conversation

gabrielmer
Copy link

@gabrielmer gabrielmer commented Oct 28, 2024

Integrating and implementing features to dial, drop and retrieve connected peers.

Important changes:

  • implemented DialPeer(), DropPeer() and PeerCount() functions
  • renamed GetNumConnectedPeers to GetNumConnectedRelayPeers
  • added test for the dialing feature
  • fixed flaky test

This PR depends on the new libwaku procedures exposed in waku-org/nwaku#3149
Once the nwaku PR is merged, I will update the nwaku submodule in this PR

Issue: waku-org/nwaku#3076

richard-ramos and others added 12 commits October 15, 2024 18:22
- some minor progress to add nwaku in status-go
- nwaku.go: GetNumConnectedPeers controls when passed pubsub is empty
- waku_test.go: adapt TestWakuV2Store
- add missing shard.go
- feat_: build nwaku with nix and use build tags to choose between go-waku and nwaku (#5896)
- chore_: update nwaku
- nwaku bump (#5911)
- bump: nwaku
- chore: add USE_NWAKU env flag
- fix: build libwaku only if needed
- feat: testing discovery and dialing with nwaku integration (#5940)
Copy link

github-actions bot commented Oct 28, 2024

We require commits to follow the Conventional Commits, but with _ for non-breaking changes.
Please fix these commit messages:

implementing feedback
fix flaky test
integrating waku_get_connected_peers and fixing test
changing function name to specify that only connected relay peers are returned
initial dialPeer implementation
implementing PeerCount and DropPeer

@status-im-auto
Copy link
Member

status-im-auto commented Oct 28, 2024

Jenkins Builds

Click to see older builds (5)
Commit #️⃣ Finished (UTC) Duration Platform Result
✖️ d7290d4 #1 2024-10-28 10:48:20 ~1 min tests 📄log
✔️ d7290d4 #1 2024-10-28 10:51:12 ~4 min ios 📦zip
✔️ d7290d4 #1 2024-10-28 10:51:31 ~5 min linux 📦zip
✔️ d7290d4 #1 2024-10-28 10:51:49 ~5 min tests-rpc 📄log
✔️ d7290d4 #1 2024-10-28 10:52:39 ~6 min android 📦aar
Commit #️⃣ Finished (UTC) Duration Platform Result
✖️ e1ab9d3 #2 2024-10-28 11:45:12 ~1 min tests 📄log
✔️ e1ab9d3 #2 2024-10-28 11:45:38 ~2 min android 📦aar
✔️ e1ab9d3 #2 2024-10-28 11:46:12 ~2 min linux 📦zip
✔️ e1ab9d3 #2 2024-10-28 11:46:49 ~3 min ios 📦zip
✔️ e1ab9d3 #2 2024-10-28 11:49:12 ~5 min tests-rpc 📄log
✖️ a87b625 #3 2024-10-28 15:51:48 ~1 min tests 📄log
✔️ a87b625 #3 2024-10-28 15:52:24 ~2 min android 📦aar
✔️ a87b625 #3 2024-10-28 15:52:48 ~2 min linux 📦zip
✔️ a87b625 #3 2024-10-28 15:53:25 ~3 min ios 📦zip
✖️ a87b625 #3 2024-10-28 15:55:55 ~5 min tests-rpc 📄log

Copy link

codecov bot commented Oct 28, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
23 1 22 0
View the top 1 failed tests by shortest run time
tests.test_router.TestTransactionFromRoute test_tx_from_route
Stack Traces | 10.6s run time
tests/test_router.py:114: in test_tx_from_route
    assert tx_details["to"] == user_2.address
E   AssertionError: assert '0x70997970C5...50e0d17dc79C8' == '0x70997970c5...50e0d17dc79c8'
E     - 0x70997970c51812dc3a010c7d01b50e0d17dc79c8
E     ?           ^        ^   ^                ^
E     + 0x70997970C51812dc3A010C7d01b50e0d17dc79C8
E     ?           ^        ^   ^                ^

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@gabrielmer gabrielmer changed the title feat: peers leftovers feat: dial, drop and retrieve peers Oct 28, 2024
@gabrielmer gabrielmer changed the title feat: dial, drop and retrieve peers feat: dial, drop and retrieve connected peers Oct 28, 2024
@gabrielmer gabrielmer marked this pull request as ready for review October 28, 2024 11:44
@gabrielmer gabrielmer requested review from richard-ramos and Ivansete-status and removed request for richard-ramos October 28, 2024 11:45
@gabrielmer gabrielmer self-assigned this Oct 28, 2024
Copy link
Member

@richard-ramos richard-ramos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! just left some minor comments

wakuv2/nwaku.go Outdated Show resolved Hide resolved
wakuv2/nwaku.go Outdated Show resolved Hide resolved
Copy link
Contributor

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for it! 💯

@richard-ramos richard-ramos force-pushed the feature/nwaku-in-status branch 2 times, most recently from e829dea to fd9d9f3 Compare October 29, 2024 16:31
@gabrielmer
Copy link
Author

Closing this PR in favor of #6013 , as there are big conflicts with the base branch

@gabrielmer gabrielmer closed this Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants