Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: Doesn't support name and white screen if open Wallet 1st time after opening transaction screen from Dapp #4876

Closed
annadanchenko opened this issue Jun 20, 2018 · 1 comment · Fixed by #4885
Assignees
Milestone

Comments

@annadanchenko
Copy link

annadanchenko commented Jun 20, 2018

Description

Type: Bug

Summary: Error: Doesn't support name is shown if user opens Wallet for the first time. If close error message then white screen is shown, so user needs to close app and launch again. If open Wallet after app re-launch then it works fine and shows Wallet screen.

Such error happens if user opened some Send Transaction screen from any DApp (e.g use Sign feature in CryptoKitties) prior to opening Wallet. If user does not interact with Dapp then Wallet can be opened fine for the first time.

Expected behavior

No error shown, Wallet screen is opened

Actual behavior

If open wallet then error is shown:

00:57 E/ReactNativeJS: Error: Doesn't support name: 
00:57 E/ReactNativeJS: 
00:57 E/ReactNativeJS: This error is located at:
00:57 E/ReactNativeJS:     in asset-selector
00:57 E/ReactNativeJS:     in reagent79
00:57 E/ReactNativeJS:     in RCTView
00:57 E/ReactNativeJS:     in RCTView
00:57 E/ReactNativeJS:     in RCTScrollView
00:57 E/ReactNativeJS:     in ScrollView
00:57 E/ReactNativeJS:     in RCTView
00:57 E/ReactNativeJS:     in RCTView
00:57 E/ReactNativeJS:     in reagent11
00:57 E/ReactNativeJS:     in reagent56
00:57 E/ReactNativeJS:     in reagent76
00:57 E/ReactNativeJS:     in send-transaction
00:57 E/ReactNativeJS:     in reagent75
00:57 E/ReactNativeJS:     in RCTView
00:57 E/ReactNativeJS:     in main
00:57 E/ReactNativeJS:     in root
00:57 E/ReactNativeJS:     in reagent1
00:57 E/ReactNativeJS:     in RCTView
00:57 E/ReactNativeJS:     in RCTView
00:57 E/ReactNativeJS:     in t

Reproduction

from 00:22 https://app.testfairy.com/projects/4803622-status/builds/8501358/sessions/4394474390/?accessToken=/pX7AYEvRo5MHjOTpineB7jZWSU

  • Open Status and create account
  • if on mainnet: Open CryptoKitties and Sign in (so there is Sign transaction done). if on ropsten: use Test Dapp -> Transactions - Sign and sign transaction
  • open Wallet for the first time, confirm that you've wrote down 3 words and proceed to Wallet screen

Note: on the morning nightly build these issue can't be reproduced but can be reproduced on new nightly triggered in the evening June 20. Merges that were included in the new nightly https://jenkins.status.im/job/status-react/job/nightly/459/changes with this issue:

  1. disable gradle daemon to make builds more stable (commit: 499f5b0) (details)
  2. [Text input is broken for Korean, Chinese, Japanese characters #4829] Add a patch that fixes complex input on iOS in RN 0.55.x. (commit: caba84e) (details)
  3. feature Add token support to send commands #3233 Allow requesting tokens from chat #4095 and Allow requesting token from wallet #3234 - send and request tokens in chat and (commit: 32bbf4e) (details)
  4. [Transaction send message is not shown in chat when skipping Got It button #4821] send /send command before after sending transaction (befor (commit: 6028cca) (details)
  5. ["Welcome to Status" image has low quality on Samsung Galaxy S8 screen #3642]: High quality welcome image (commit: 41dcb2e) (details)
  6. Add 6 new languages as public channels in the localized language. Closes (commit: 2270146) (details)

Additional Information

@asemiankevich
Copy link
Contributor

asemiankevich commented Jun 20, 2018

@goranjovic it is #4796 :( please take a look tomorrow (

@asemiankevich asemiankevich added this to the Beta milestone Jun 20, 2018
goranjovic added a commit that referenced this issue Jun 21, 2018
goranjovic added a commit that referenced this issue Jun 21, 2018
…ded stricter check for chat wallet onboarding
jeluard pushed a commit that referenced this issue Jun 22, 2018
…ded stricter check for chat wallet onboarding

Signed-off-by: Julien Eluard <[email protected]>
jeluard pushed a commit that referenced this issue Jun 22, 2018
…ded stricter check for chat wallet onboarding

Signed-off-by: Julien Eluard <[email protected]>
mandrigin pushed a commit that referenced this issue Jun 25, 2018
mandrigin pushed a commit that referenced this issue Jun 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants