bug #4921 - adds a workaround for the conflicting bugs #4876 and #4755

[goranjovic]

fixes #4921

Summary:

We've got two bugfixes causing each other's bugs.

If we clear :from-chat? from transaction, then we lose the read only state in chat transactions when user clicks cancel or say tries to sign with incorrect password. (bug #4755)

If we don't clear :from-chat? then if we have a dapp transaction before wallet onboarding has been done, then app will think that there is a chat tx in progress and will redirect to onboarding. Since there is no chat tx the app will crash (bug #4876)

This PR adds a workaround to have a special partial clean function for transactions started from chat - one that cleans everything except :from-chat? property. This will prevent the fields from getting unlocked and would not cause the onboarding crash since with chat transactions onboarding should happen before we get to this screen anyway (there is interception).

This is merely a hotfix. A proper solution would involve:

• adding onboarding interception for dapp transactions to avoid the Error: Doesn't support name and white screen if open Wallet 1st time after opening transaction screen from Dapp #4876 scenario altogether. (issue User should be redirected to wallet onboarding before signing transaction in dapp #4724)
• fixing the transaction creation and signing to be a one step process to avoid the Read-only fields Amount, Asset and Recipient can be modified if cancel signinig transaction  #4755 scenario altogether - there would be no intermediate step with a half done tx after cancel or fail. (issue Get rid of transactions queue status-go#1027)

Steps to test:

test for #4876 and #4755

status: ready

[jeluard]

Could you create an issue to track this today? Sounds like this is some area we want to clean sooner than later.

[status-comment-bot]

branch PR-4924:
apk uploaded to https://i.diawi.com/m4cXLV
ipa uploaded to https://i.diawi.com/ngCyUj

Install - Diawi - Development and In-house Apps Wireless Installation

Install - Diawi - Development and In-house Apps Wireless Installation

[statustestbot]

94% of end-end tests have passed

Total executed tests: 33
Failed tests: 2
Passed tests: 31

Failed tests (2)

Click to expand

1. test_resend_message_offline

Looking for full text: 'test message' Wait for ChatElementByText E Failed: Progress indicator is shown during 17.29950891714543 seconds Device sessions: Device 1 Device 2

2. test_sign_message_from_daap

Looking for StatusTestDAppButton Looking for StatusTestDAppButton E AttributeError: 'NoneType' object has no attribute 'click' Device sessions: Device 1

Passed tests (31)

Click to expand

1. test_sign_transaction_twice

Device sessions: Device 1

2. test_swipe_and_delete_1_1_chat

Device sessions: Device 1

3. test_one_to_one_chat_messages

Device sessions: Device 1 Device 2

4. test_copy_and_paste_messages

Device sessions: Device 1

5. test_send_transaction_from_daap

Device sessions: Device 1

6. test_faucet_console_command

Device sessions: Device 1

7. test_username_and_profile_picture_in_chats

Device sessions: Device 1 Device 2

8. test_send_eth_from_wallet_sign_now

Device sessions: Device 1

9. test_offline_login

Device sessions: Device 1

10. test_open_transaction_on_etherscan

Device sessions: Device 1

11. test_send_eth_to_request_from_wallet

Device sessions: Device 1 Device 2

12. test_incorrect_password

Device sessions: Device 1

13. test_backup_seed_phrase_and_recover_account

Device sessions: Device 1

14. test_offline_messaging_1_1_chat

Device sessions: Device 1 Device 2

15. test_contact_profile_view

Device sessions: Device 1

16. test_public_chat

Device sessions: Device 1 Device 2

17. test_public_chat_management

Device sessions: Device 1 Device 2

18. test_network_switch

Device sessions: Device 1

19. test_delete_1_1_chat

Device sessions: Device 1

20. test_messaging_in_different_networks

Device sessions: Device 1 Device 2

21. test_wallet_error_messages

Device sessions: Device 1

22. test_transaction_send_command_one_to_one_chat

Device sessions: Device 1

23. test_network_mismatch_for_send_request_commands

Device sessions: Device 1 Device 2

24. test_browse_link_entering_url_in_dapp_view

Device sessions: Device 1

25. test_transaction_send_command_wrong_password

Device sessions: Device 1

26. test_send_eth_to_request_in_one_to_one_chat

Device sessions: Device 1 Device 2

27. test_profile_picture

Device sessions: Device 1

28. test_switch_users

Device sessions: Device 1

29. test_set_up_wallet

Device sessions: Device 1

30. test_send_stt_from_wallet_via_enter_recipient_address

Device sessions: Device 1

31. test_qr_code_and_its_value

Device sessions: Device 1

[Serhy]

Looks good! Could not reproduce #4921 and #4876 and #4755 issues.
There is a similar issue to #4876 described in #4930 which is reproduced for me here as well.

Two failed autotest rechecked manually and they are OK, team notified to look at them.

[mandrigin]

@Serhy okay, merging :)