nix: use jsbundle derivation for iOS as well #15924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (26)
|
jakubgs
force-pushed
the
ios/nix-built-jsbundle
branch
4 times, most recently
from
eed8a14
to
ee82820
Compare
siddarthkay
approved these changes
May 17, 2023
|
I tested this branch locally and found no issues in building and running the app on IOS Simulator. |
ajayesivan
reviewed
May 17, 2023
ajayesivan
approved these changes
May 17, 2023
jakubgs
force-pushed
the
ios/nix-built-jsbundle
branch
2 times, most recently
from
41d3f55
to
d99c614
Compare
jo-mut
approved these changes
May 17, 2023
jakubgs
force-pushed
the
ios/nix-built-jsbundle
branch
from
d99c614
to
bda302a
Compare
For some unknown to me reason we are using a different Yarn call to Shadow-cljs to generate the JSBundle for iOS builds, while the one created by the Android derivation shoudl be exactly the same. I'm changing the target to just be `make jsbundle` while keeping aliases referencing old naming, and moving things around in `nix` folder to reflect the fact that the derivation is no longer Android-specific. Also, crucially, I've changed the `import` in `index.js` to use the `./result/index.js` path, since that's what Nix creates. I'm not sure if this clashes with any developer workflow that takes place locally, so I'd appreciate some testing from developers. Depends on: status-im/status-jenkins-lib#67 Signed-off-by: Jakub Sokołowski <[email protected]>
jakubgs
force-pushed
the
ios/nix-built-jsbundle
branch
from
bda302a
to
58d2096
Compare
jakubgs
added a commit
that referenced
this pull request
May 30, 2023
Forgot to update this in: #15924 Signed-off-by: Jakub Sokołowski <[email protected]>
jakubgs
added a commit
that referenced
this pull request
May 30, 2023
Forgot to update this in: #15924 Signed-off-by: Jakub Sokołowski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some unknown to me reason we are using a different Yarn call to Shadow-cljs to generate the JSBundle for iOS builds, while the one created by the Android derivation shoudl be exactly the same. I'm changing the target to just be
make jsbundlewhile keeping aliases referencing old naming, and moving things around innixfolder to reflect the fact that the derivation is no longer Android-specific.Also, crucially, I've changed the
importinindex.jsto use the./result/index.jspath, since that's what Nix creates. I'm not sure if this clashes with any developer workflow that takes place locally, so I'd appreciate some testing from developers.Depends on: