Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nix: use jsbundle derivation for iOS as well #15924

Merged
merged 1 commit into from
May 22, 2023
Merged

nix: use jsbundle derivation for iOS as well #15924

merged 1 commit into from
May 22, 2023

Commits on May 22, 2023

  1. nix: use jsbundle derivation for iOS as well 

    For some unknown to me reason we are using a different Yarn call to
Shadow-cljs to generate the JSBundle for iOS builds, while the one
created by the Android derivation shoudl be exactly the same.

I'm changing the target to just be `make jsbundle` while keeping aliases
referencing old naming, and moving things around in `nix` folder to
reflect the fact that the derivation is no longer Android-specific.

Also, crucially, I've changed the `import` in `index.js` to use the
`./result/index.js` path, since that's what Nix creates. I'm not sure if
this clashes with any developer workflow that takes place locally, so
I'd appreciate some testing from developers.

Depends on: status-im/status-jenkins-lib#67

Signed-off-by: Jakub Sokołowski <[email protected]>
    @jakubgs
    jakubgs committed May 22, 2023
    Configuration menu
    Copy the full SHA
    58d2096 View commit details
    Browse the repository at this point in the history