Added Debug level log in Relocalization #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: ymd-stella <[email protected]>
Co-authored-by: ymd-stella <[email protected]>
ymd-stella
requested changes
Aug 27, 2021
There was a problem hiding this comment.
- num_candidates should be displayed before entering the loop.
- Show the ID of the candidate keyframe, not the ID of the frame.
- Don't forget the space after
. - Show the values that affected the decision.
I have given an example of correction in only one place, so please refer to it and correct the others as well.
ymd-stella
requested changes
Aug 30, 2021
Co-authored-by: ymd-stella <[email protected]>
Co-authored-by: ymd-stella <[email protected]>
ymd-stella
requested changes
Aug 30, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added debug level log in relocalizer.cc #141