Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GPL infringing code #252

Merged
merged 22 commits into from
Feb 6, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
46fc2aa
Fix frame/keyframe (Remove GPL infringing code)
ymd-stella Feb 6, 2022
f8e8c00
Fix graph_node (Remove GPL infringing code)
ymd-stella Feb 6, 2022
fa7be12
Fix landmark (Remove GPL infringing code)
ymd-stella Feb 6, 2022
a47618c
Fix map_database (Remove GPL infringing code)
ymd-stella Feb 6, 2022
5efcf7d
Fix frame_publicher (Remove GPL infringing code (Remove overlay text))
ymd-stella Feb 6, 2022
949f583
Fix pangolin_viewer (Remove GPL infringing code)
ymd-stella Feb 6, 2022
ab069fd
Fix about request (Remove GPL infringing code)
ymd-stella Feb 6, 2022
8f694b3
Remove temporary variables for tracking (Remove GPL infringing code)
ymd-stella Feb 6, 2022
3555ef1
Fix mapping_module (Remove GPL infringing code)
ymd-stella Feb 6, 2022
3f36bed
Remove temporary variables for loop closing (Remove GPL infringing co…
ymd-stella Feb 6, 2022
2b31692
Remove duplicated code in loop_detector (Remove GPL infringing code)
ymd-stella Feb 6, 2022
1d84318
Fix orb_extractor (Remove GPL infringing code)
ymd-stella Feb 6, 2022
57a6b8e
Minimize unnecessary functions (Remove GPL infringing code)
ymd-stella Feb 6, 2022
f6373e3
Move depth_thr to camera (Remove GPL infringing code)
ymd-stella Feb 6, 2022
9cf7bdc
Update config files (Move depth_thr to Camera)
ymd-stella Feb 6, 2022
7261b49
Update feature extraction parameters (Remove GPL infringing code)
ymd-stella Feb 6, 2022
fe7f411
Remove database from keyframe/frame (Remove GPL infringing code)
ymd-stella Feb 6, 2022
44d0774
Add fame_observation (Remove GPL infringing code)
ymd-stella Feb 6, 2022
ef7a2c0
Fix match::projection (Remove GPL infringing code)
ymd-stella Feb 6, 2022
aaf1c4c
Fix tracking (Remove GPL infringing code)
ymd-stella Feb 6, 2022
883c418
Fix missing #include <cmath>
ymd-stella Feb 6, 2022
711f4b0
Add NOTE to README.md
ymd-stella Feb 6, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

---

> *NOTE:* This is a community fork of [xdspacelab/openvslam](https://github.com/xdspacelab/openvslam). It was created to continue active development of OpenVSLAM on Jan 31, 2021. The original repository is no longer available. Please read the [official statement of termination](https://github.com/xdspacelab/openvslam/wiki/Termination-of-the-release) carefully and understand it before using this. If you are interested in a more detailed discussion, see [here](https://github.com/OpenVSLAM-Community/openvslam/issues/37).
> *NOTE:* This is a community fork of [xdspacelab/openvslam](https://github.com/xdspacelab/openvslam). It was created to continue active development of OpenVSLAM on Jan 31, 2021. The original repository is no longer available. Please read the [official statement of termination](https://github.com/xdspacelab/openvslam/wiki/Termination-of-the-release) carefully and understand it before using this. The similarities with ORB_SLAM2 in the original version have been removed by <https://github.com/OpenVSLAM-Community/openvslam/pull/252>. If you find any other issues with the license, please point them out. See <https://github.com/OpenVSLAM-Community/openvslam/issues/37> and <https://github.com/OpenVSLAM-Community/openvslam/issues/249> for discussion so far.

---

Expand Down
42 changes: 37 additions & 5 deletions docs/parameters.rst
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@ Camera
* - focal_x_baseline
- For stereo cameras, it is the value of the baseline between the left and right cameras multiplied by the focal length fx.
For RGBD cameras, if the measurement method is stereo, set it based on its baseline. If the measurement method is other than that, set the appropriate value based on the relationship between depth accuracy and baseline.
* - depth_threshold
- The ratio used to determine the depth threshold.

.. _section-parameters-feature:

Expand All @@ -53,6 +55,8 @@ Feature

* - Name
- Description
* - name
- name of ORB feature extraction model (id for saving)
* - scale_factor
- Scale of the image pyramid
* - num_levels
Expand All @@ -62,10 +66,10 @@ Feature
* - min_fast_threshold
- FAST threshold for try second time

.. _section-parameters-tracking:
.. _section-parameters-preprocessing:

Tracking
========
Preprocessing
=============

.. list-table::
:header-rows: 1
Expand All @@ -77,10 +81,20 @@ Tracking
- Maximum number of feature points per frame to be used for SLAM.
* - ini_max_num_keypoints
- Maximum number of feature points per frame to be used for Initialization. It is only used for monocular camera models.
* - depth_threshold
- The ratio used to determine the depth threshold.
* - depthmap_factor
- The ratio used to convert depth image pixel values to distance.

.. _section-parameters-tracking:

Tracking
========

.. list-table::
:header-rows: 1
:widths: 1, 3

* - Name
- Description
* - reloc_distance_threshold
- Maximum distance threshold (in meters) where close keyframes could be found when doing a relocalization by pose.
* - reloc_angle_threshold
Expand Down Expand Up @@ -164,6 +178,24 @@ Relocalizer
* - min_num_valid_obs
-

.. _section-parameters-keyframe-inserter:

KeyframeInserter
================

.. list-table::
:header-rows: 1
:widths: 1, 3

* - Name
- Description
* - max_interval
- max interval to insert keyframe
* - lms_ratio_thr_almost_all_lms_are_tracked
- Threshold at which we consider that we are tracking almost all landmarks. Ratio-threshold of "the number of 3D points observed in the current frame" / "that of 3D points observed in the last keyframe"
* - lms_ratio_thr_view_changed
- Threshold at which we consider the view to have changed. Ratio-threshold of "the number of 3D points observed in the current frame" / "that of 3D points observed in the last keyframe"

.. _section-parameters-pangolin:

PangolinViewer
Expand Down
13 changes: 7 additions & 6 deletions example/aist/equirectangular.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,23 +19,24 @@ Camera:
# Tracking Parameters #
#=====================#

Tracking:
Preprocessing:
max_num_keypoints: 2000
mask_rectangles:
- [0.0, 1.0, 0.0, 0.1]
- [0.0, 1.0, 0.84, 1.0]
- [0.0, 0.2, 0.7, 1.0]
- [0.8, 1.0, 0.7, 1.0]

#================#
# ORB Parameters #
#================#

Feature:
name: "default ORB feature extraction setting"
scale_factor: 1.2
num_levels: 8
ini_fast_threshold: 20
min_fast_threshold: 7
mask_rectangles:
- [0.0, 1.0, 0.0, 0.1]
- [0.0, 1.0, 0.84, 1.0]
- [0.0, 0.2, 0.7, 1.0]
- [0.8, 1.0, 0.7, 1.0]

#====================#
# Mapping Parameters #
Expand Down
3 changes: 2 additions & 1 deletion example/aist/fisyeye.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -29,14 +29,15 @@ Camera:
# Tracking Parameters #
#=====================#

Tracking:
Preprocessing:
max_num_keypoints: 2000

#================#
# orb parameters #
#================#

Feature:
name: "default ORB feature extraction setting"
scale_factor: 1.2
num_levels: 8
ini_fast_threshold: 20
Expand Down
3 changes: 2 additions & 1 deletion example/euroc/EuRoC_mono.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ Camera:
# Tracking Parameters #
#=====================#

Tracking:
Preprocessing:
max_num_keypoints: 1000
ini_max_num_keypoints: 2000

Expand All @@ -39,6 +39,7 @@ Tracking:
#================#

Feature:
name: "default ORB feature extraction setting"
scale_factor: 1.2
num_levels: 8
ini_fast_threshold: 20
Expand Down
5 changes: 3 additions & 2 deletions example/euroc/EuRoC_stereo.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ Camera:
cols: 752
rows: 480
focal_x_baseline: 47.90639384423901
depth_threshold: 40

color_order: "Gray"

Expand All @@ -55,16 +56,16 @@ StereoRectifier:
# Tracking Parameters #
#=====================#

Tracking:
Preprocessing:
max_num_keypoints: 1000
ini_max_num_keypoints: 2000
depth_threshold: 40

#================#
# ORB Parameters #
#================#

Feature:
name: "default ORB feature extraction setting"
scale_factor: 1.2
num_levels: 8
ini_fast_threshold: 20
Expand Down
3 changes: 2 additions & 1 deletion example/kitti/KITTI_mono_00-02.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ Camera:
# Tracking Parameters #
#=====================#

Tracking:
Preprocessing:
max_num_keypoints: 2000
ini_max_num_keypoints: 4000

Expand All @@ -39,6 +39,7 @@ Tracking:
#================#

Feature:
name: "default ORB feature extraction setting"
scale_factor: 1.2
num_levels: 8
ini_fast_threshold: 20
Expand Down
3 changes: 2 additions & 1 deletion example/kitti/KITTI_mono_03.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ Camera:
# Tracking Parameters #
#=====================#

Tracking:
Preprocessing:
max_num_keypoints: 2000
ini_max_num_keypoints: 4000

Expand All @@ -39,6 +39,7 @@ Tracking:
#================#

Feature:
name: "default ORB feature extraction setting"
scale_factor: 1.2
num_levels: 8
ini_fast_threshold: 20
Expand Down
3 changes: 2 additions & 1 deletion example/kitti/KITTI_mono_04-12.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ Camera:
# Tracking Parameters #
#=====================#

Tracking:
Preprocessing:
max_num_keypoints: 2000
ini_max_num_keypoints: 4000

Expand All @@ -39,6 +39,7 @@ Tracking:
#================#

Feature:
name: "default ORB feature extraction setting"
scale_factor: 1.2
num_levels: 8
ini_fast_threshold: 20
Expand Down
5 changes: 3 additions & 2 deletions example/kitti/KITTI_stereo_00-02.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,23 +24,24 @@ Camera:
cols: 1241
rows: 376
focal_x_baseline: 386.1448
depth_threshold: 40

color_order: "Gray"

#=====================#
# Tracking Parameters #
#=====================#

Tracking:
Preprocessing:
max_num_keypoints: 2000
ini_max_num_keypoints: 4000
depth_threshold: 40

#================#
# ORB Parameters #
#================#

Feature:
name: "default ORB feature extraction setting"
scale_factor: 1.2
num_levels: 8
ini_fast_threshold: 12
Expand Down
5 changes: 3 additions & 2 deletions example/kitti/KITTI_stereo_03.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,23 +24,24 @@ Camera:
cols: 1242
rows: 375
focal_x_baseline: 387.5744
depth_threshold: 40

color_order: "Gray"

#=====================#
# Tracking Parameters #
#=====================#

Tracking:
Preprocessing:
max_num_keypoints: 2000
ini_max_num_keypoints: 4000
depth_threshold: 40

#================#
# ORB Parameters #
#================#

Feature:
name: "default ORB feature extraction setting"
scale_factor: 1.2
num_levels: 8
ini_fast_threshold: 12
Expand Down
5 changes: 3 additions & 2 deletions example/kitti/KITTI_stereo_04-12.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,23 +24,24 @@ Camera:
cols: 1226
rows: 370
focal_x_baseline: 379.8145
depth_threshold: 40

color_order: "Gray"

#=====================#
# Tracking Parameters #
#=====================#

Tracking:
Preprocessing:
max_num_keypoints: 2000
ini_max_num_keypoints: 4000
depth_threshold: 40

#================#
# ORB Parameters #
#================#

Feature:
name: "default ORB feature extraction setting"
scale_factor: 1.2
num_levels: 8
ini_fast_threshold: 12
Expand Down
3 changes: 2 additions & 1 deletion example/tum_rgbd/TUM_RGBD_mono_1.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ Camera:
# Tracking Parameters #
#=====================#

Tracking:
Preprocessing:
max_num_keypoints: 1000
ini_max_num_keypoints: 2000

Expand All @@ -39,6 +39,7 @@ Tracking:
#================#

Feature:
name: "default ORB feature extraction setting"
scale_factor: 1.2
num_levels: 8
ini_fast_threshold: 20
Expand Down
3 changes: 2 additions & 1 deletion example/tum_rgbd/TUM_RGBD_mono_2.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ Camera:
# Tracking Parameters #
#=====================#

Tracking:
Preprocessing:
max_num_keypoints: 1000
ini_max_num_keypoints: 2000

Expand All @@ -39,6 +39,7 @@ Tracking:
#================#

Feature:
name: "default ORB feature extraction setting"
scale_factor: 1.2
num_levels: 8
ini_fast_threshold: 20
Expand Down
3 changes: 2 additions & 1 deletion example/tum_rgbd/TUM_RGBD_mono_3.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ Camera:
# Tracking Parameters #
#=====================#

Tracking:
Preprocessing:
max_num_keypoints: 1000
ini_max_num_keypoints: 2000

Expand All @@ -39,6 +39,7 @@ Tracking:
#================#

Feature:
name: "default ORB feature extraction setting"
scale_factor: 1.2
num_levels: 8
ini_fast_threshold: 20
Expand Down
5 changes: 3 additions & 2 deletions example/tum_rgbd/TUM_RGBD_rgbd_1.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,24 +24,25 @@ Camera:
cols: 640
rows: 480
focal_x_baseline: 40.0
depth_threshold: 40.0

color_order: "RGB"

#=====================#
# Tracking Parameters #
#=====================#

Tracking:
Preprocessing:
max_num_keypoints: 1000
ini_max_num_keypoints: 2000
depth_threshold: 40.0
depthmap_factor: 5000.0 # Note: Set it to 1.0 for the rosbag format data set.

#================#
# ORB Parameters #
#================#

Feature:
name: "default ORB feature extraction setting"
scale_factor: 1.2
num_levels: 8
ini_fast_threshold: 20
Expand Down
Loading