-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SEP-24 interactive URL token iat: set grace period to 5 minutes #667
Conversation
Hey Yuri, thanks for addressing this. We actually added a similar solution at the Stellar SDK level for SEP-10 tokens. In that case we actually added a much more forgiving grace period of 5 minutes. Can we do the same for the interactive URL JWT? |
Yes, done |
@JakeUrban Not sure about clock syncing though. The only clock involved is the server one, since |
5 minutes might be overkill for this specific issue |
Oh you're right, my mistake. Clock drift would only be relevant when the client has to check the server's expiration. |
No problem, I reverted back the change, 1 second seems to be sufficient |
PR is ready on my side, feel free to merge |
I'm working on removing the CircleCI check -- we're moving to GH actions. Then I'll merge & release the patch. |
resolves #666