Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle events without contract IDs correctly #172

Merged
merged 5 commits into from
Dec 1, 2023
Merged

Conversation

Shaptic
Copy link
Contributor

@Shaptic Shaptic commented Nov 27, 2023

This mirrors stellar/js-stellar-sdk#883.

It also adds a migration guide with justifications and details alongside a deprecation message that people will see when installing soroban-client.

@Shaptic Shaptic self-assigned this Nov 30, 2023
@Shaptic Shaptic added the bug Something isn't working label Nov 30, 2023
Copy link
Contributor

@sreuland sreuland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Shaptic Shaptic merged commit 3fff672 into main Dec 1, 2023
4 checks passed
@Shaptic Shaptic deleted the deprecation-message branch December 1, 2023 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants