Handle events without contract IDs correctly #883
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported on Discord and confirmed by an example in the docs, the
SorobanRpc.Server.getEvents
method will fail when the event response contains an empty contract ID. There was an implicit assumption in the code that it would always be present and valid, but in fact it can sometimes be empty.This modifies the
parseRawEvents
code to omit thecontractId
field from the parsed response.