Extending classes no dir #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this PR require #143 to be merged first, or does this PR need to be merged first? |
In theory it's either or. I am not sure which would be easier to merge. I would merge this first |
Merged
This fixes the codes import errors an enables it to run. However, pylint will error saying it cannot import, which is less of a priority than the code running.
Inheriting from "Exception" is still broad and we can use specific exceptions for more detail
Slack and GitHub classes have been broken down into further classes to help atomise the module. Also, moved to use data classes over dictionaries as they make the code much cleaner read and easier to work with.
Changes to how default values are handled and docstrings
khalford
force-pushed
the
extending_classes_no_dir
branch
from
fe702be
to
413afc0
Compare
anish-mudaraddi
previously approved these changes
Jun 25, 2024
meoflynn
requested changes
Jun 26, 2024
meoflynn
requested changes
Jul 15, 2024
anish-mudaraddi
approved these changes
Aug 21, 2024
meoflynn
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch extends the current classes and improves the code readability using dataclasses.
The pylint errors here are fixed in #143