Change dir #143
Merged
Change dir #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the codes import errors an enables it to run. However, pylint will error saying it cannot import, which is less of a priority than the code running.
Inheriting from "Exception" is still broad and we can use specific exceptions for more detail
Slack and GitHub classes have been broken down into further classes to help atomise the module. Also, moved to use data classes over dictionaries as they make the code much cleaner read and easier to work with.
Changed this to fix issues with Pylint and Python importing.
With this directory structure: Pylint, Pytest and Python all show no errors.
meoflynn
requested changes
Jun 17, 2024
Changed this to fix issues with Pylint and Python importing.
With this directory structure: Pylint, Pytest and Python all show no errors.
meoflynn
previously approved these changes
Sep 2, 2024
anish-mudaraddi
requested changes
Sep 5, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #143 +/- ##
===========================================
- Coverage 97.20% 81.08% -16.13%
===========================================
Files 66 3 -63
Lines 3046 74 -2972
===========================================
- Hits 2961 60 -2901
+ Misses 85 14 -71
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
anish-mudaraddi
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the directory structure as Pylint and Python are not importing the same as each other and one will bug out.