Remove orquesta #241
Merged
Remove orquesta #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove class - use functions instead. Now openstack_project we now take `conn` - openstack connection object for each function remove unnecessary functions
refactor tests for openstack_identity
MAINT: refactor Openstack API openstack_identity
we re-implement this class as standalone functions Split this into network, router and subnet modules We've removed unnecessary methods
update tests for new functions
now its just standalone functions - much easier to read and understand
update tests for new function
convert to simpler function
not needed at the moment since find_user is only used in one place
convert to simpler functions
re-work openstack api security group tests to work with new functions
disable too-many-arguments for test
MAINT: Refactor Openstack API - openstack_roles
MAINT: Openstack API Refactor - security groups
MAINT: Openstack API refactor - quota
added docstring for fixture
MAINT: refactor Openstack API - network
this will delete dead code no longer needed
MAINT: delete dead code
rewrite project creation without orquesta TODO: rewrite actions and tests
no need to set descriptions so remove them, I will remove the need to provide a description in the api functions in a follow up PR
PROTO: project creation scripts without orquesta
This is so we can remove all the unnecessary code under actions.src.*. We're only keeping useful actions here - other ones can be easily done using openstack cli so we shouldn't re-invent the wheel here
PROTO: moving useful actions into workflow folder
These actions were used by orquesta workflow but now that we've got python functions for creating internal and external projects, we don't need to maintain these actions - so we'll remove them. Some of these make no sense to maintain as standalone actions
These were entrypoints for now deleted actions and so no longer needed
Actions that require access to openstack now all go through openstack_actions.py We define an lib_entry_point for each action which tells us how to forward on requests to functions that will handle the request in the lib layer.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #241 +/- ##
==========================================
+ Coverage 98.05% 98.20% +0.14%
==========================================
Files 187 195 +8
Lines 8298 7636 -662
Branches 521 460 -61
==========================================
- Hits 8137 7499 -638
+ Misses 135 110 -25
- Partials 26 27 +1 ☔ View full report in Codecov by Sentry. |
Refactor entrypoints for openstack actions
was previously string which caused issues
limit find_security_group to project we're creating before creating rules
was setting default to to_str instead of to_string breaking the enum choice
these aren't needed and we don't use them when creating the project anymore
external project workflow params need to match action
we can't call the api directly we need to use workflows as the middle-layer to handle any anciliary parts like logging
setting default quota and adding field for security group rules quota in external project create action
This now matches old orquesta workflow
gmatthews20
reviewed
Sep 23, 2024
changes to docstrings and comments mainly
The way stackstorm is designed means this is always going to be an issue
gmatthews20
previously approved these changes
Sep 24, 2024
|
This has been tested and has been confirmed to work on dev |
DavidFair
reviewed
Sep 24, 2024
DavidFair
previously approved these changes
Sep 24, 2024
anish-mudaraddi
force-pushed
the
remove-orquesta
branch
from
8d33111
to
2468e98
Compare
DavidFair
approved these changes
Sep 24, 2024
gmatthews20
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This feature branch removes orquesta workflows entirely
Special Notes:
Submitter:
Have you (where applicable):
Reviewer
Does this PR:
libdirectory?liblayers?