-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does not respect guidelines in VS2022 version #300
Comments
Hmm nothing's changed at this end, so I suspect something's changed/broken w.r.t. the Editor Guidelines extension. For me it still works if you add the guidelines manually in the code window; I've never actually used the .editorconfig feature there. Will have to investigate. |
…om editorconfig (#300) In this case they aren't written to the registry (makes sense). Thankfully we can sniff them out from the IWpfTextView adornments.
If it was working in 2019 then I don't know how! Rewrap only read the guidelines from the registry, but Anyway, I've added a change so it can now read the guidelines straight from the editor. It will be in the next version. |
Haha, I have no idea. It's possible that I added that guideline before I started using Thanks for the feature update though! |
Thank you! I hadn't looked into the capabilities of Editor Guidelines in a long while, so didn't really know about its .editorconfig support. It's nice that I can use that extension to provide it in this one too. |
…om editorconfig (#300) In this case they aren't written to the registry (makes sense). Thankfully we can sniff them out from the IWpfTextView adornments.
- New architecture (still WIP) with performance increase. - Markdown: new parser that fixes many small bugs (inc #288), as well as supporting: - Front matter header (#277, #294) - Link reference definitions (#63, #93) - Footnotes (#188) - ReStructuredText support (standalone & for Python, almost complete) (#88). - Julia: support `#= ... =#` block comments (#302) - Visual Studio: Wrap to rulers generated from .editorconfig by the Editor Guidelines extension (thereby indirectly supporting .editorconfig) (#300).
Fixed in v1.16.0 |
I'm not sure that this is working correctly. I did a new VS install and it's not wrapping to the 160 char width guideline I have set in |
@mikernet can you post your .editorconfig file? |
If you want the whole thing here you go, but the relevant line is line 9. It wraps to the default 80 char width. The only guideline I see in my code editor is the 160 line.
|
Thanks, I will investigate |
OK I can repro. For some reason the published build (1.16.0.300) is broken (apparently I was still using a beta build myself which was working). Could you try downloading and installing the pre-release version Rewrap-VS-17.6.vsix? That version is working again for me. |
I've now published v1.16.2. For me it's working in that version |
The 2019 version works fine but in VS2022 it does not seem to respect the guideline I have setup in .editorconfig:
It always wraps to whatever the setting is in VS options. I have the
Editor Guidelines
extension also installed which shows the guideline in the correct location.The text was updated successfully, but these errors were encountered: