Potential call to null.equals(null) in JSONObject.

[drguildo]

Both valueToString and writeValue have method calls of the form value.equals(null). If value is equal to null then a call to null.equals(null) is going to fail with a NullPointerException.

[douglascrockford]

Please show me how this can potentially raise a NullPointerException:

if (value == null || value.equals(null)) {
    return "null";
}

[drguildo]

Sorry, you're right, it can't; but in the case where value is null, the second check (value.equals(null)) is either completely pointless (because the previous check has determined that it is null) or raises a NullPointerException (because it is null and trying to call equals on it results in a NullPointerException).

bsh % String foo = null;
bsh % foo.equals(null);
// Error: // Uncaught Exception: null : at Line: 1 : in file: <unknown file> : foo .equals ( null ) 

Target exception: java.lang.NullPointerException: Null Pointer in Method Invocation

[douglascrockford]

Don't be filing bugs in your code against me.