Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: dedupe results by unique fingerprint #856

Merged
merged 9 commits into from
Dec 20, 2019
Merged

feat: dedupe results by unique fingerprint #856

merged 9 commits into from
Dec 20, 2019

Conversation

marbemac
Copy link
Contributor

@marbemac marbemac commented Dec 16, 2019 •
edited by P0lip
Loading

Checklist

  • Tests added / updated
  • Docs added / updated

Does this PR introduce a breaking change?

  • Yes

Duplicate lint results are no longer reported.

@marbemac marbemac requested a review from P0lip December 16, 2019 00:36
@marbemac marbemac mentioned this pull request Dec 16, 2019
Merged
4 tasks
@marbemac
Copy link
Contributor Author

Alright, combined deduplicateResults and cleaned up tests since things are always sorted now.

The karma tests are not working for whatever reason, will need some help @P0lip to get tests across finish line. No rush.

@P0lip
Copy link
Contributor

P0lip commented Dec 19, 2019

Karma tests fail since the entire src/formatters directory is excluded, as the code there is meant to be used by CLI. I'll move sortResults function as it's used by the core Spectral part now.

P0lip
P0lip reviewed Dec 19, 2019
View reviewed changes
Copy link
Contributor

@P0lip P0lip left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments. Looking awesome.
I updated certain parts of code on my own.
Mostly removed the sortResults calls that were no longer required, since you already sort out results in the run method.

src/utils/prepareResults.ts Outdated Show resolved Hide resolved
src/utils/prepareResults.ts Outdated Show resolved Hide resolved
src/spectral.ts Outdated Show resolved Hide resolved
P0lip
P0lip previously approved these changes Dec 20, 2019
View reviewed changes
Copy link
Contributor

@P0lip P0lip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed.

@github-actions github-actions bot merged commit 952ccfe into develop Dec 20, 2019
@P0lip P0lip deleted the fix/improve-results branch December 20, 2019 11:22
@disposedtrolley disposedtrolley mentioned this pull request Jan 16, 2020
Closed
@nulltoken nulltoken mentioned this pull request Mar 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nulltoken nulltoken nulltoken left review comments

@P0lip P0lip P0lip approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marbemac @P0lip @nulltoken