Prebundle with tsup #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmeasday
approved these changes
Nov 3, 2022
7 tasks
This was referenced Dec 1, 2022
Merged
This was referenced Dec 14, 2022
5 tasks
5 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: N/A
What Changed
Use
tsupto package into a single file rather than transpiling with babelThis is especially useful because MDX2 is an ESM-only package, and we still use CJS in parts of the Storybook ecosystem (e.g. Jest). This allows us to get rid of all the weird hacks & async imports we were doing in the previous version.
How to test
Change Type
maintenancedocumentationpatchminormajor📦 Published PR as canary version:
0.0.4-canary.23.5394b4c.0✨ Test out this PR locally via:
Version
Published prerelease version:
v0.1.0-next.4Changelog
🚀 Enhancement
AddContext#14 (@tmeasday)🐛 Bug Fix
Authors: 4