Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSX: Ignore the user's babel config #31

Merged
merged 2 commits into from
Dec 14, 2022
Merged

Conversation

shilman
Copy link
Member

@shilman shilman commented Dec 14, 2022

Issue: N/A

What Changed

Something in the babel config handling was messed up:

ARN 🚨 Extraction error on src/stories/renderers/react/react-mdx.stories.mdx: TypeError: /tmp/storybook/sandbox/react-webpack-17-ts/.babelrc: Error while parsing config - _json(...).parse is not a function

Instead just ignore user's settings

How to test

Change Type

  • maintenance
  • documentation
  • patch
  • minor
  • major
📦 Published PR as canary version: 0.0.4-canary.31.46da497.0

✨ Test out this PR locally via:

npm install @storybook/[email protected]
# or 
yarn add @storybook/[email protected]

Version

Published prerelease version: v1.0.0-next.1

Changelog

💥 Breaking Change

  • Add JSX transpilation to compiler-generated code #30 (@ndelangen)

🚀 Enhancement

🐛 Bug Fix

⚠️ Pushed to next

Authors: 8

@shilman shilman added the bug Something isn't working label Dec 14, 2022
@shilman shilman marked this pull request as ready for review December 14, 2022 13:19
@shilman
Copy link
Member Author

shilman commented Dec 14, 2022

self-merging @ndelangen we might need to revisit the ESM thing later

@shilman shilman merged commit 7c3390b into next Dec 14, 2022
@shilman shilman deleted the shilman/fix-babel-config branch December 14, 2022 13:26
@ndelangen
Copy link
Member

Thanks for this @shilman 👏

@github-actions github-actions bot mentioned this pull request Dec 30, 2022
5 tasks
@github-actions github-actions bot mentioned this pull request Jan 6, 2023
5 tasks
@github-actions github-actions bot mentioned this pull request Jan 21, 2023
5 tasks
This was referenced Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants