-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't require storyshots users to transform lodash-es
#2570
Comments
Can we programmatically add to the user's jest config? Feels a little hacky, but then storyshots is pretty hacky ;) It's probably too late in the piece to do it though :/ |
The only other option I can think of is to use something like |
I don't think |
Hmm.. Shit. I've Forgotten about people need their own jest config. Storyshots already use babel-core internally maybe we can somehow use it for that? |
It also overrides |
This line is the place the exception comes from (it isn't clear from the stack trace): |
Why? |
DIdn't work for me, |
Jest overrides require itself I guess. It doesn't seem like they are compatible. |
If we want to try and get it working with Jest we should probably follow these for insights into a non-hacky solution: jestjs/jest#4842 jestjs/jest#2205 |
This is a breaking change and is causing test failures for us |
Will revert it today |
This was fixed and released in 3.3.3 |
Issue details
As part of #2558 we added a dependency on
lodash-es
, an uncompiled JS dependency.This means that Jest needs to be configured to transform the file with:
within each users' storyshots-using project.
Steps to reproduce
Create a storyshots project with 3.3.
The text was updated successfully, but these errors were encountered: