-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move everything from lodash to lodash-es #2558
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2558 +/- ##
=======================================
Coverage 32.69% 32.69%
=======================================
Files 398 398
Lines 8837 8837
Branches 947 965 +18
=======================================
Hits 2889 2889
+ Misses 5298 5259 -39
- Partials 650 689 +39
Continue to review full report at Codecov.
|
@@ -14,6 +14,7 @@ module.exports = { | |||
'<rootDir>/examples/cra-kitchen-sink', | |||
'<rootDir>/examples/official-storybook', | |||
], | |||
transformIgnorePatterns: ['/node_modules/(?!lodash-es/.*)'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this something that storyshots users will need to do too?
Issue: After latest changes in angular the entire
lodash
package is bundled.What I did
Changed lodash to lodash-es in. This way we can import specific method without installing the lodash.* package (that have issues with @types)