Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move everything from lodash to lodash-es #2558

Merged
merged 8 commits into from
Dec 24, 2017
Merged

Conversation

igor-dv
Copy link
Member

@igor-dv igor-dv commented Dec 24, 2017

Issue: After latest changes in angular the entire lodash package is bundled.

What I did

Changed lodash to lodash-es in. This way we can import specific method without installing the lodash.* package (that have issues with @types)

@codecov
Copy link

codecov bot commented Dec 24, 2017

Codecov Report

Merging #2558 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2558   +/-   ##
=======================================
  Coverage   32.69%   32.69%           
=======================================
  Files         398      398           
  Lines        8837     8837           
  Branches      947      965   +18     
=======================================
  Hits         2889     2889           
+ Misses       5298     5259   -39     
- Partials      650      689   +39
Impacted Files Coverage Δ
app/react/src/client/preview/element_check.js 67.64% <ø> (ø) ⬆️
addons/knobs/src/components/Panel.js 81.03% <ø> (ø) ⬆️
lib/ui/src/modules/ui/libs/filters.js 47.36% <ø> (ø) ⬆️
lib/ui/src/modules/ui/containers/layout.js 12.5% <ø> (ø) ⬆️
lib/ui/src/modules/shortcuts/actions/shortcuts.js 22.41% <ø> (ø) ⬆️
lib/ui/src/modules/api/actions/api.js 51.85% <ø> (ø) ⬆️
...modules/ui/components/stories_panel/text_filter.js 30.98% <0%> (ø) ⬆️
...i/src/modules/ui/components/stories_panel/index.js 18.51% <0%> (ø) ⬆️
app/react/src/server/config/babel.js 0% <0%> (-100%) ⬇️
app/vue/src/server/utils.js 0% <0%> (-53.58%) ⬇️
... and 55 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afaeefa...3714159. Read the comment docs.

@Hypnosphi Hypnosphi added maintenance User-facing maintenance tasks patch:yes Bugfix & documentation PR that need to be picked to main branch labels Dec 24, 2017
@igor-dv igor-dv requested review from xavxyz and removed request for xavxyz December 24, 2017 19:52
@Hypnosphi Hypnosphi merged commit 154e7a3 into master Dec 24, 2017
@Hypnosphi Hypnosphi deleted the move-lodash-to-lodash-es branch December 24, 2017 21:46
@@ -14,6 +14,7 @@ module.exports = {
'<rootDir>/examples/cra-kitchen-sink',
'<rootDir>/examples/official-storybook',
],
transformIgnorePatterns: ['/node_modules/(?!lodash-es/.*)'],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this something that storyshots users will need to do too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants