Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Story Hierarchy (UI improvements) #1387

Merged
merged 20 commits into from
Jul 2, 2017
Merged

Story Hierarchy (UI improvements) #1387

merged 20 commits into from
Jul 2, 2017

Conversation

igor-dv
Copy link
Member

@igor-dv igor-dv commented Jun 29, 2017

Issue: #151

What I did

I've added react-treebeard and react-icons for a better look and feel of the stories hierarchy

storybook_hierarchy_react-treebeard-2

How to test

Run cra-kitchen-sink or storybook-ui-example

@codecov
Copy link

codecov bot commented Jun 29, 2017 •
edited
Loading

Codecov Report

Merging #1387 into release/3.2 will increase coverage by 0.19%.
The diff coverage is 69.47%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release/3.2    #1387      +/-   ##
===============================================
+ Coverage        15.29%   15.49%   +0.19%     
===============================================
  Files              202      238      +36     
  Lines             4706     5499     +793     
  Branches           627      648      +21     
===============================================
+ Hits               720      852     +132     
- Misses            3456     4100     +644     
- Partials           530      547      +17
Impacted Files Coverage Δ
...b/ui/src/modules/ui/components/left_panel/index.js 100% <ø> (ø) ⬆️
...mponents/left_panel/stories_tree/tree_node_type.js 0% <0%> (ø)
...i/components/left_panel/stories_tree/tree_style.js 0% <0%> (ø)
lib/ui/src/modules/ui/libs/hierarchy.js 47.16% <0%> (-2.04%) ⬇️
...les/ui/components/left_panel/stories_tree/index.js 100% <100%> (ø)
...ponents/left_panel/stories_tree/tree_decorators.js 39.02% <42.1%> (ø)
addons/knobs/src/components/Panel.js 86.07% <0%> (-1.93%) ⬇️
.../src/manager/containers/CommentsPanel/dataStore.js 34.78% <0%> (ø) ⬆️
addons/knobs/src/index.js 0% <0%> (ø) ⬆️
... and 74 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80f7ab2...f048d32. Read the comment docs.

@igor-dv igor-dv added this to the v3.2.0 milestone Jun 29, 2017
@igor-dv igor-dv added the ui label Jun 29, 2017
@igor-dv igor-dv requested review from shilman and usulpro July 1, 2017 10:48
@igor-dv
Copy link
Member Author

igor-dv commented Jul 1, 2017

@shilman , @usulpro
I've forked the react-treebeard, so now this branch is working without warnings. I would be glad to get the review =) (and merge)

usulpro
usulpro reviewed Jul 1, 2017
View reviewed changes
lib/ui/src/modules/ui/components/left_panel/stories/tree_node_type.js Outdated
export default {
NAMESPACE: 'namespace',
COMPONENT: 'component',
STORY: 'story',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe it's worth to add some comments about new UI structure. I'd like to dig a bit this (and previous) PR so it could help to review

shilman
shilman reviewed Jul 2, 2017
View reviewed changes
lib/ui/src/modules/ui/components/left_panel/stories/index.js Outdated
@@ -0,0 +1,155 @@
import reactTreebeard from 'storybook-react-treebeard';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import { Treebeard } from ...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

shilman
shilman reviewed Jul 2, 2017
View reviewed changes
lib/ui/src/modules/ui/components/left_panel/stories/tree_decorators.js Outdated
@@ -0,0 +1,76 @@
import reactTreebeard from 'storybook-react-treebeard';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import { decorators } from ...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep.. But it didn't work (they changed the export of the index file in the PR) But I am changing it in the forked version to the named export and it should fix this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@shilman
Copy link
Member

shilman commented Jul 2, 2017

@igor-dv i have some issues with the current state, but am merging/releasing anyway. i'll list them as separate issues that we can work through during the alpha stage

@shilman shilman merged commit b26e39b into release/3.2 Jul 2, 2017
This was referenced Jul 7, 2017
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@usulpro usulpro usulpro left review comments

@shilman shilman shilman left review comments

Assignees
No one assigned
Labels
feature request ui
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@igor-dv @shilman @usulpro @arunoda