-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Story Hierarchy - initial state bug fix #1401
Conversation
Codecov Report
@@ Coverage Diff @@
## release/3.2 #1401 +/- ##
==============================================
+ Coverage 15.82% 15.9% +0.07%
==============================================
Files 237 237
Lines 5043 5050 +7
Branches 625 619 -6
==============================================
+ Hits 798 803 +5
- Misses 3725 3729 +4
+ Partials 520 518 -2
Continue to review full report at Codecov.
|
currentSelectedHierarchy.length === nextSelectedHierarchy.length && | ||
currentSelectedHierarchy.every((item, index) => item === nextSelectedHierarchy[index]) | ||
) { | ||
return; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if(!deepEquals(currentHierarchy, nextHierarchy)) {
const selectedNodes ...
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see suggestion above @igor-dv
Issue: #151
What I did
I've added
componentWillReceiveProps
to thestories_tree/index.js
that will recalculate the selected nodes according to the provided selected hierarchy.How to test
run
cra-kitchen-sink