Webpack: Expand version ranges of webpack in the apps (same as app/react) #17834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit b5edf10. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
|
@shilman perhaps something worthy of a patch? |
I can try it in an alpha version first if you want to be extra sure! I'm using the latest next version of Storybook |
shilman
changed the title
shilman
approved these changes
Mar 31, 2022
| @@ -80,7 +80,7 @@ | |||
| "ts-loader": "^8.0.14", | |||
| "tsconfig-paths-webpack-plugin": "^3.3.0", | |||
| "util-deprecate": "^1.0.2", | |||
| "webpack": "4" | |||
| "webpack": ">=4.0.0 <6.0.0" | |||
There was a problem hiding this comment.
React's is a bit different. Do we care?
"webpack": ">=4.43.0 <6.0.0"
There was a problem hiding this comment.
didn't want to introduce new constraints
|
I tested the latest alpha that includes this PR and did a fresh re-install (deleted node_modules, package-lock.json, npm install) However, there are still webpack v4 versions deeply nested. The good thing is that npm does not want to hoist them Here's the result of |
This was referenced Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Seems in some apps we have a direct dependency on webpack "4", when it should be a dependency on any version between 4 & 5 since we started supporting webpack 5.
@kroeder alerted me on dependency issues relating to angular, and I looked around the codebase and concluded this problem existed in a few more frameworks.
What I did
I made the version of webpack we depend on a bigger range. This is exactly how we do it already for app/react.