Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webpack: Expand version ranges of webpack in the apps (same as app/react) #17834

Merged
merged 3 commits into from
Mar 31, 2022
Merged

Webpack: Expand version ranges of webpack in the apps (same as app/react) #17834

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
22d118b
chsnge version ranges of webpack in the apps (same as app/react)
ndelangen Mar 31, 2022
5ba27cc
Merge branch 'next' into tech/improve-version-range-webpack
ndelangen Mar 31, 2022
b5edf10
Merge branch 'next' into tech/improve-version-range-webpack
ndelangen Mar 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions app/angular/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@
"ts-loader": "^8.0.14",
"tsconfig-paths-webpack-plugin": "^3.3.0",
"util-deprecate": "^1.0.2",
"webpack": "4"
"webpack": ">=4.0.0 <6.0.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

React's is a bit different. Do we care?

    "webpack": ">=4.43.0 <6.0.0"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't want to introduce new constraints

},
"devDependencies": {
"@angular-devkit/architect": "~0.1102.0",
Expand All @@ -101,7 +101,8 @@
"jest": "^26.6.3",
"jest-preset-angular": "^8.3.2",
"jest-specific-snapshot": "^4.0.0",
"tmp": "^0.2.1"
"tmp": "^0.2.1",
"webpack": "4"
},
"peerDependencies": {
"@angular-devkit/architect": ">=0.8.9",
Expand Down
3 changes: 3 additions & 0 deletions app/html/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,9 @@
"read-pkg-up": "^7.0.1",
"regenerator-runtime": "^0.13.7",
"ts-dedent": "^2.0.0",
"webpack": ">=4.0.0 <6.0.0"
},
"devDependencies": {
"webpack": "4"
},
"peerDependencies": {
Expand Down
9 changes: 5 additions & 4 deletions app/preact/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,15 +59,16 @@
"react-dom": "16.14.0",
"read-pkg-up": "^7.0.1",
"regenerator-runtime": "^0.13.7",
"ts-dedent": "^2.0.0"
"ts-dedent": "^2.0.0",
"webpack": ">=4.0.0 <6.0.0"
},
"devDependencies": {
"preact": "^10.5.13"
"preact": "^10.5.13",
"webpack": "4"
},
"peerDependencies": {
"@babel/core": "*",
"preact": "^8.0.0||^10.0.0",
"webpack": "*"
"preact": "^8.0.0||^10.0.0"
},
"engines": {
"node": ">=10.13.0"
Expand Down
5 changes: 3 additions & 2 deletions app/svelte/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,13 +63,14 @@
"regenerator-runtime": "^0.13.7",
"sveltedoc-parser": "4.1.0",
"ts-dedent": "^2.0.0",
"webpack": "4"
"webpack": ">=4.0.0 <6.0.0"
},
"devDependencies": {
"@types/loader-utils": "^2.0.0",
"@types/webpack-env": "^1.16.0",
"svelte": "^3.31.2",
"svelte-loader": "^3.0.0"
"svelte-loader": "^3.0.0",
"webpack": "4"
},
"peerDependencies": {
"@babel/core": "*",
Expand Down
5 changes: 3 additions & 2 deletions app/vue/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,12 +64,13 @@
"ts-loader": "^8.0.14",
"vue-docgen-api": "^4.44.15",
"vue-docgen-loader": "^1.5.0",
"webpack": "4"
"webpack": ">=4.0.0 <6.0.0"
},
"devDependencies": {
"vue": "^2.6.12",
"vue-loader": "^15.9.6",
"vue-template-compiler": "^2.6.12"
"vue-template-compiler": "^2.6.12",
"webpack": "4"
},
"peerDependencies": {
"@babel/core": "*",
Expand Down
5 changes: 3 additions & 2 deletions app/vue3/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,11 +64,12 @@
"vue-docgen-api": "^4.44.15",
"vue-docgen-loader": "^1.5.0",
"vue-loader": "^16.0.0",
"webpack": "4"
"webpack": ">=4.0.0 <6.0.0"
},
"devDependencies": {
"@vue/compiler-sfc": "3.0.0",
"vue": "3.0.0"
"vue": "3.0.0",
"webpack": "4"
},
"peerDependencies": {
"@babel/core": "*",
Expand Down
2 changes: 1 addition & 1 deletion yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8006,10 +8006,10 @@ __metadata:
read-pkg-up: ^7.0.1
regenerator-runtime: ^0.13.7
ts-dedent: ^2.0.0
webpack: 4
peerDependencies:
"@babel/core": "*"
preact: ^8.0.0||^10.0.0
webpack: "*"
bin:
build-storybook: ./bin/build.js
start-storybook: ./bin/index.js
Expand Down