-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Support Storybook 7.0 #207
Conversation
Socket Security ReportDependency issues detected. If you merge this pull request, you will not be alerted to the instances of these issues again. 📜 New install scripts detectedA dependency change in this PR is introducing new install scripts to your install step.
Socket.dev scan summary
Bot CommandsTo ignore an alert, reply with a comment starting with
Powered by socket.dev |
Codecov ReportBase: 77.24% // Head: 76.53% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## next #207 +/- ##
==========================================
- Coverage 77.24% 76.53% -0.72%
==========================================
Files 13 11 -2
Lines 189 179 -10
Branches 41 37 -4
==========================================
- Hits 146 137 -9
+ Misses 43 42 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
I changed to this canary in my project, and initially got Despite that hiccup, I think this is the correct solution, unless you want to have versions of the test-runner that support 6.x and others for 7.x, which sounds like a nightmare. |
Can this support pnpm and yarn pnp? Or it has to be on another pr? I have missing dependency errors. My workaround has been adding the dependencies directly to my package.json. Can you fix it like in other storybook packages in the main repo? |
@bryanjtc would you open an issue with the details of what you're seeing? |
#208 Here |
Superseded by #210 |
Fixes #200
This moves the Storybook core packages from
dependencies
intopeerDependencies
and opens up the the range to allow 7.0 pre-release versions. And also adds them todevDependencies
, and updates all the storybook devDeps to 7.0.And it updates the example project to 7.0.
📦 Published PR as canary version:
0.9.1--canary.207.e1be268.0
✨ Test out this PR locally via: