Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Support Storybook 7.0 #207

Closed
wants to merge 3 commits into from
Closed

Feat: Support Storybook 7.0 #207

wants to merge 3 commits into from

Conversation

IanVS
Copy link
Member

@IanVS IanVS commented Oct 14, 2022

Fixes #200

This moves the Storybook core packages from dependencies into peerDependencies and opens up the the range to allow 7.0 pre-release versions. And also adds them to devDependencies, and updates all the storybook devDeps to 7.0.

And it updates the example project to 7.0.

📦 Published PR as canary version: 0.9.1--canary.207.e1be268.0

✨ Test out this PR locally via:

npm install @storybook/[email protected]
# or 
yarn add @storybook/[email protected]

@socket-security
Copy link

socket-security bot commented Oct 14, 2022

Socket Security Report

Dependency issues detected. If you merge this pull request, you will not be alerted to the instances of these issues again.

📜 New install scripts detected

A dependency change in this PR is introducing new install scripts to your install step.

Package Script field Location
[email protected] (upgraded) postinstall package.json via @storybook/[email protected], @storybook/[email protected], @pmmmwh/[email protected]
[email protected] (added) postinstall package.json via @storybook/[email protected]
Socket.dev scan summary
Issue Status
Did you mean? ✅ no new possible package typos
Install scripts ⚠️ 2 new install scripts detected
Telemetry ✅ no new telemetry
Troll package ✅ no new troll packages
Malware ✅ no new malware
Native code ✅ no new native modules
Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] [email protected]

⚠️ Please accept the latest app permissions to ensure bot commands work properly. Accept the new permissions here.

Powered by socket.dev

@codecov-commenter
Copy link

Codecov Report

Base: 77.24% // Head: 76.53% // Decreases project coverage by -0.71% ⚠️

Coverage data is based on head (e1be268) compared to base (12fcb67).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             next     #207      +/-   ##
==========================================
- Coverage   77.24%   76.53%   -0.72%     
==========================================
  Files          13       11       -2     
  Lines         189      179      -10     
  Branches       41       37       -4     
==========================================
- Hits          146      137       -9     
+ Misses         43       42       -1     
Impacted Files Coverage Δ
.storybook/preview.js
.storybook/is-test-runner.js

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@IanVS
Copy link
Member Author

IanVS commented Oct 14, 2022

I changed to this canary in my project, and initially got Cannot find module '@storybook/core-common'. I think this is because previously there were two different versions, so the 7.0 version got nested into @storybook/builder-vite rather than the top-level of node_modules. Removing node_modules and the package-lock, and reinstalling solved the issue. And now my tests run correctly.

Despite that hiccup, I think this is the correct solution, unless you want to have versions of the test-runner that support 6.x and others for 7.x, which sounds like a nightmare.

@IanVS IanVS requested a review from yannbf October 14, 2022 15:55
@bryanjtc
Copy link
Member

Can this support pnpm and yarn pnp? Or it has to be on another pr? I have missing dependency errors. My workaround has been adding the dependencies directly to my package.json. Can you fix it like in other storybook packages in the main repo?

@IanVS
Copy link
Member Author

IanVS commented Oct 15, 2022

@bryanjtc would you open an issue with the details of what you're seeing?

@bryanjtc
Copy link
Member

#208 Here

@shilman
Copy link
Member

shilman commented Oct 22, 2022

Superseded by #210

@shilman shilman closed this Oct 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Cannot use with ESM storybook config file
4 participants