Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grammar in the "TypeScript development" docs #2184

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

imcarlosguerrero
Copy link
Contributor

What does it do?

Rewrites "is" to "are" in the warning about the right path to import types from in the TypeScript development documentation.

Why is it needed?

To ensure clarity.

Note: This is also written in the same way in the beta docs.

Corrected grammar in the TypeScript development docs regarding the proper path for importing types.
Copy link

vercel bot commented Aug 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 26, 2024 2:11am

Copy link
Collaborator

@pwizla pwizla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @imcarlosguerrero.

The PR is now approved, merged, should be live on docs.strapi.io in a few minutes, and will be mentioned in the next weekly snapshot release.

@pwizla pwizla merged commit 5364fb4 into strapi:main Aug 29, 2024
3 checks passed
@pwizla pwizla added this to the 4.25.10 milestone Aug 29, 2024
@pwizla pwizla added source: Dev Docs PRs/issues targeting the Developer Docs pr: fix Used on the docs repo for anything that is not "new" or "updated" content: chore, typos, fixes, etc. labels Aug 29, 2024
@imcarlosguerrero imcarlosguerrero deleted the patch-1 branch September 3, 2024 19:11
@pwizla pwizla modified the milestones: 4.25.10, 4.25.12 Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fix Used on the docs repo for anything that is not "new" or "updated" content: chore, typos, fixes, etc. source: Dev Docs PRs/issues targeting the Developer Docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants