Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grammar in the "TypeScript development" docs #2232

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

imcarlosguerrero
Copy link
Contributor

What does it do?

Rewrites "is" to "are" in the warning about the right path to import types from in the TypeScript development documentation.

Why is it needed?

To ensure clarity.

Related issue(s)/PR(s)

The change has already been made in the v4 documentation #2184.

Copy link

vercel bot commented Sep 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2024 9:26pm

Copy link
Collaborator

@pwizla pwizla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @imcarlosguerrero.

The PR is now approved, merged, should be live on docs.strapi.io in a few minutes, and will be mentioned in the next weekly snapshot release.

@pwizla pwizla self-assigned this Sep 23, 2024
@pwizla pwizla added source: Dev Docs PRs/issues targeting the Developer Docs pr: fix Used on the docs repo for anything that is not "new" or "updated" content: chore, typos, fixes, etc. labels Sep 23, 2024
@pwizla pwizla added this to the 5.1.0 milestone Sep 23, 2024
@pwizla pwizla merged commit ffb78b3 into strapi:main Sep 23, 2024
3 checks passed
@pwizla pwizla added the temp: port to doc6 (Temporary label) The content of this PR should be ported to Strapi Docs v6 label Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fix Used on the docs repo for anything that is not "new" or "updated" content: chore, typos, fixes, etc. source: Dev Docs PRs/issues targeting the Developer Docs temp: port to doc6 (Temporary label) The content of this PR should be ported to Strapi Docs v6
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants