Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maintenance update #538

Merged
merged 1 commit into from
Jun 10, 2024
Merged

maintenance update #538

merged 1 commit into from
Jun 10, 2024

Conversation

strasdat
Copy link
Owner

@strasdat strasdat commented Jun 9, 2024

The goal of this PR is to make Sophus future-proof and easier to maintain. In particular, it removes outdated code, updates to more modern workflows, and incorporates newer toolchains and dependencies, hopefully without causing any major backwards compatibility issues.

  • Largely simplifies logging and formatting by removing optionality and reverting to an earlier approach for log formatting.

  • Newer toolchains and dependencies

    • Moved from C++14 to C++17. This allows the use of std::optional in the API and eliminates the need for a hand-rolled optional type.
    • Eigen 3.4
    • New version of Ceres, HEAD of master (for CI)
  • CI

    • Larger overhaul of the main.yml CI action
      • Addition of several newer targets such as ubuntu-24.04 and macOS-14
      • New "install_tests" which test a "sudo make install" followed by an example target "linking" against the installed Sophus library
      • Example usages in CI of the SOPHUS_ENABLE_ENSURE_HANDLER, which has been around for a long time but is largely unknown. This is particularly useful for those who prefer to throw exceptions on ENSURE failures instead of a panic (e.g., Sophus ensure calls abort() #533)
    • (Re)-enable pybind CI - though it is currently failing, see Cannot compile sophus_pybind in Ubuntu 20.04 #537
  • Removed old/outdated code:

    • sophus/ceres_local_parameterization.hpp, which is not supported by newer Ceres versions anymore and is superseded by sophus/ceres_manifold.hpp
    • Experimental sophus/velocities.hpp
  • Remove hosted Sophus docs folders/toolchain

    • The actual Sophus 1 docs have not been working/hosted for several years now, and re-enabling/maintaining them is too large of a burden...
  • Modern format and linting using pre-commit

  • Content format and update to the top-level README

@strasdat strasdat marked this pull request as draft June 9, 2024 02:27
@strasdat strasdat force-pushed the maintenance-update-jun2024 branch 29 times, most recently from f588a62 to 78a7b3a Compare June 9, 2024 04:44
@strasdat strasdat force-pushed the maintenance-update-jun2024 branch 13 times, most recently from 4cc574e to 1a02566 Compare June 10, 2024 04:36
@strasdat strasdat marked this pull request as ready for review June 10, 2024 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant