Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vcpkg installation instructions #377

Closed
wants to merge 4 commits into from

Conversation

FrankXie05
Copy link
Contributor

@FrankXie05 FrankXie05 commented Sep 9, 2022

Sophus is available as a port in vcpkg, a C++ library manager that simplifies installation for Sophus and other project dependencies. Documenting the install process here will help users get started by providing a single set of commands to build Sophus, ready to be included in their projects.

We also test whether our library ports build in various configurations (dynamic, static) on various platforms (OSX, Linux, Windows: x86, x64) to keep a wide coverage for users.

I'm a maintainer for vcpkg, and here is what the port script looks like. We try to keep the library maintained as close as possible to the original library. 😊

@coveralls
Copy link

coveralls commented Sep 9, 2022

Coverage Status

Coverage remained the same at 98.733% when pulling c4a9050 on FrankXie05:vcpkg-instructions into 0422cad on strasdat:master.

@FrankXie05
Copy link
Contributor Author

Error form macos-10.15 https://github.com/strasdat/Sophus/runs/8264461555?check_suite_focus=true

/usr/local/include/fmt/core.h:1756:3: error: static_assert failed due to requirement 'formattable' "Cannot format an argument. To make type T formattable provide a formatter<T> specialization: https://fmt.dev/latest/api.html#udt"
  static_assert(
  ^

It looks like the reason for the failure is that the fmt library is passing a type that doesn't provide a formatting method. Is it because of the currently unsupported fmt version? 🤔

@FrankXie05
Copy link
Contributor Author

@strasdat

@NikolausDemmel
Copy link
Contributor

Yes, looks like #376 will need to be merged for CI succeed.

@FrankXie05
Copy link
Contributor Author

FrankXie05 commented Sep 16, 2022

PR #376 has been merged, reopen PR to rerun CI tests

@FrankXie05 FrankXie05 closed this Sep 16, 2022
@FrankXie05 FrankXie05 reopened this Sep 16, 2022
@FrankXie05
Copy link
Contributor Author

@strasdat This PR is ready for review.

@strasdat
Copy link
Owner

@FrankXie05, sorry it has been some time, and I just pushed a larger update (#538). If you are still interested, I'd be happy to coordinate...

@FrankXie05
Copy link
Contributor Author

@strasdat Need me to do something? :)

@strasdat
Copy link
Owner

@FrankXie05 thanks for the PR! I think I'm a little confused since I would have expected a vcpk.json in the root of the Sophus repository. Maybe it got deleted at some point...

Nevertheless, I tried out the instructions against the current port versions and they worked. Hence I will rebase your change and get the instructions in. I'll open an issue/PR against vcpkg later to update the version.

@strasdat strasdat closed this Jun 11, 2024
@FrankXie05 FrankXie05 deleted the vcpkg-instructions branch June 12, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants