Fix bugs found in stratisd#2949 #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbaublitz
force-pushed
the
stratisd-start-stop
branch
from
7073478
to
35bd858
Compare
mulkieran
approved these changes
Apr 13, 2022
jbaublitz
force-pushed
the
stratisd-start-stop
branch
from
35bd858
to
eb25d8b
Compare
This commit fixes a few bugs: * Cache handles can now be created * Cache file path in get_cache() is now optional and passing in None uses the default * Fixed a double free in the cache handle when put_cache() is called
jbaublitz
force-pushed
the
stratisd-start-stop
branch
from
eb25d8b
to
2e0f3af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to stratis-storage/stratisd#2949
The main things I discovered:
get_cacherequired a mandatory file path to the cache whenNoneshould trigger the default path (what most users want)cache_putwould cause a double freeOnce we merge and release this, perhaps we should yank 0.1.0. This is likely not a big issue because no one could create the cache object to trigger the double free anyway but that's a rather large piece of the interface that's broken.