Add ability to start and stop pools #2949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbaublitz
force-pushed
the
start-stop
branch
2 times, most recently
from
8b71434
to
bf0eb39
Compare
|
|
|
Expect udev tests to fail |
jbaublitz
force-pushed
the
start-stop
branch
5 times, most recently
from
ab56cd9
to
d2e9830
Compare
|
Blocked by stratis-storage/libblkid-rs#75 |
mulkieran
requested changes
Jun 15, 2022
mulkieran
approved these changes
Jun 16, 2022
jbaublitz
force-pushed
the
start-stop
branch
2 times, most recently
from
28dd77b
to
399f7b4
Compare
|
@jbaublitz Plz squash the commits a bit and I'll go ahead and merge. |
|
Blocked by #3027 |
|
@mulkieran @bmr-cymru I found a bug in signal handling with the switch from LockedPools to StoppedPools. I've pushed an additional commit and am putting this back in review. |
mulkieran
approved these changes
Jun 23, 2022
bmr-cymru
approved these changes
Jun 23, 2022
This commit replaces the previous approach of unlocking encrypted pools with full support for starting and stopping pools. Locked encrypted pools are now simply considered stopped. The behavior of stopping pools is as follows. A pool that is started when the system shuts down will be started after booting the system again. A pool that is stopped will remain stopped and will not be set up until it is started again. This operation requires a change to the metadata schema to store whether a pool is stopped or started. Migration from older versions of stratisd is handled. Stopping an encrypted pool will lock all of the encrypted devices.
|
Ready for merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes stratis-storage/project#296