This repository has been archived by the owner on Apr 28, 2021. It is now read-only.
Need to work around tests on instanceof HTMLMediaElement #9
Comments
AxelDelmas
pushed a commit
that referenced
this issue
Apr 6, 2016
removed check on instanceof video, see #9
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Dash.js, and probably others, test if the video is an instance of HTMLMediaElement : https://github.com/Dash-Industry-Forum/dash.js/blob/development/src/streaming/utils/Capabilities.js#L66
We used to inherit HTMLMediaElement prototype to work around this, but it broke when updating the version (Error: illegal invocation when setting video.src): https://github.com/Dash-Industry-Forum/dash.js/blob/ae5330eb3a6112fda9f4b831b2620f4a58990b44/src/streaming/models/VideoModel.js#L88
The text was updated successfully, but these errors were encountered: