Do not use SLF4J loggers in Topic Operator classes #9619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Scholz <[email protected]>
|
/azp run feature-gates-regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Frawless
approved these changes
Jan 31, 2024
see-quick
approved these changes
Jan 31, 2024
There was a problem hiding this comment.
LGTM, but it should be reviewed by SMEs @tombentley or @fvaleri .
im-konge
approved these changes
Jan 31, 2024
adamj-m
pushed a commit
to jamesfarlow/strimzi-kafka-operator
that referenced
this pull request
Feb 1, 2024
Signed-off-by: Jakub Scholz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
It looks like 2 classes in the Topic Operator use SLF4J loggers without any obvious reasons. This is likely just by mistake because of a wrong import? This PR changes these loggers to use Log4j2 as the other classes in TO. It also removes SLF4J as a direct dependency to avoid this happening again in the future.
(It also deletes one unnecessary warning suppression)
Checklist