Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use SLF4J loggers in Topic Operator classes #9619

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Do not use SLF4J loggers in Topic Operator classes #9619

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions topic-operator/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,10 +90,6 @@
<groupId>org.apache.kafka</groupId>
<artifactId>kafka-clients</artifactId>
</dependency>
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-api</artifactId>
</dependency>
<dependency>
<groupId>com.101tec</groupId>
<artifactId>zkclient</artifactId>
Expand Down
6 changes: 3 additions & 3 deletions topic-operator/src/main/java/io/strimzi/operator/topic/KafkaStreamsTopicStoreService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@
import org.apache.kafka.streams.KafkaStreams;
import org.apache.kafka.streams.StreamsConfig;
import org.apache.kafka.streams.Topology;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;

import java.util.ArrayList;
import java.util.Collections;
Expand All @@ -36,7 +36,7 @@
* A service to configure and start/stop KafkaStreamsTopicStore.
*/
public class KafkaStreamsTopicStoreService {
private static final Logger LOGGER = LoggerFactory.getLogger(KafkaStreamsTopicStoreService.class);
private static final Logger LOGGER = LogManager.getLogger(KafkaStreamsTopicStoreService.class);

private final List<AutoCloseable> closeables = new ArrayList<>();

Expand Down
7 changes: 3 additions & 4 deletions topic-operator/src/main/java/io/strimzi/operator/topic/Zk2KafkaStreams.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
import io.strimzi.operator.topic.zk.Zk;
import io.vertx.core.CompositeFuture;
import io.vertx.core.Future;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;

import java.util.AbstractMap;
import java.util.ArrayList;
Expand All @@ -21,7 +21,7 @@
* Migration tool to move ZkTopicStore to KafkaStreamsTopicStore.
*/
public class Zk2KafkaStreams {
private static final Logger LOGGER = LoggerFactory.getLogger(Zk2KafkaStreams.class);
private static final Logger LOGGER = LogManager.getLogger(Zk2KafkaStreams.class);

protected static CompletionStage<KafkaStreamsTopicStoreService> upgrade(
Zk zk,
Expand All @@ -38,7 +38,6 @@ protected static CompletionStage<KafkaStreamsTopicStoreService> upgrade(
return service.start(config, kafkaProperties)
.thenCompose(ksTopicStore -> {
LOGGER.info("Starting upgrade ...");
@SuppressWarnings("rawtypes")
List<Future<Void>> results = new ArrayList<>();
List<String> list = zk.getChildren(topicsPath);
LOGGER.info("Topics to upgrade: {}", list);
Expand Down
Loading