-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Cantook OPDS Reader issues #346
Comments
Hey 👋 thanks for reporting this! I'll try to take a look this week at what might be happening |
thank you so much |
Hello! I retested my own app and was able to get Stump connected with Moonreader+ on Android. I used the url http://ip:port/opds/v1.2/catalog and then entered login info in the relevant fields after trying to connect to the server. If that still doesn't work you could try out this solution that worked for a couple people: https://www.reddit.com/r/KavitaManga/comments/vsf96f/cant_get_moon_reader_opds_working/?share_id=CCHumGyppVzkxtZdnNDM-&utm_name=ioscss |
@LRotenberger Thanks a lot. |
@aaronleopold still cannot make it work in Cantook. Thanks |
Happy that did the trick!
Gotcha, funny enough I actually hadn't heard of that one before you brought it up in the issue. I'll be sure to do some testing with it this week to see what might be happening |
Actually it was known before as Aldiko. Probably the best we have used in terms of UI from our side. |
I'll try and re-validate what I've found so far on Android (my old testing phone is dead right now), but on the surface this seems to be an issue with the Cantook app and not Stump after testing on my iPhone. The TLDR; is that the app does not seem to correctly parse and/or pass the authorization params you provide in the beginning of the URL as the appropriate request headers. You should be able to reproduce on your end:
I would try reaching out to the developer of that app in the meantime to see if they would be willing to support authenticated OPDS feeds with explicit configuration, or at the very least parsing legacy login params into request headers. Like I said though I will try to re-validate my findings on an Android, but if this points to an issue outside of Stump I'm inclined to close it out afterwards. Let me know if you have any questions! |
I used a bit of a keyword search to try continue figuring this out, and I actually found a reference to authenticated OPDS feeds with Cantook in one of Komga's release notes. So perhaps it is possible! However, a quick glance at the changes referenced reveal it was added to Komga's v2 OPDS API. Cantook doesn't mention what version(s) they support, though. Regardless, I went ahead and contacted the developer to see what might be going on:
|
Thanks a lot for your time, did you get any answer ? |
No problem! I haven't gotten a response yet, but I'll be sure to post an update here if/when I do |
Unfortunately after installing Moonreader+ on my tablet and adding stump catalog it asks for my credentials and after I put them it asks for credentials again and seems to be stuck in the login loop. No log on stump docker nothing is showing :( |
I assume you've already done the fix from before, without success? If so, can you create another issue with your device details to track it separately?
If no longs are showing on the Stump side, generally that means either:
https://www.stumpapp.dev/guides/configuration/server-options#stump_verbosity |
Ok here is the log: (trace log and I also added the environment variable that it is in a docker) 2024-06-04T02:56:42.633122Z TRACE stump_server::middleware::auth: No session found, checking for auth header |
I seem to be very unlucky :( 2024-06-04T14:10:08.001968357Z 2024-06-04T14:10:08.001843Z DEBUG tower_http::trace::on_request: started processing request |
Are you on Those logs are actually really helpful, and I should be able to debug what I think might be going wrong after work today. TLDR; in the latest nightly, I reorganized the OPDS router to prepare for V2 support. I think a bug has surfaced from how I re-organized which is stripping the shared 2024-06-04T14:10:08.002027768Z in tower_http::trace::make_span::request with method: GET, uri: /opds/v1.2/catalog, version: HTTP/1.1
# but then in the middleware function
2024-06-04T14:10:08.002035178Z 2024-06-04T14:10:08.001935Z TRACE stump_server::middleware::auth: Checking auth header, is_opds: false, has_auth_header: false, uri: /v1.2/catalog |
Yes nightly :) |
Thanks for confirming! If it is the bug I outlined above, it should be easy to surface and fix locally. I'll report back once I verify today If you're looking for a little more stability while using Stump, in general, I'd recommend swapping to the versioned releases in the future. |
I will try latest tag now. No big deal to start from scratch as the setup takes a couple of minutes. Will see if then it works on chunky and also on moonreader. |
@GregTroar I have put up a PR which contains a tentative fix #350. Once I also want to note, I wasn't able to test on an Android device (or specifically the MoonReader app). However, I was able to validate in the browser that the OPDS authentication was in fact broken and the changes in the PR resolved the issue. |
I did not switched yet as it was very late yesterday night for me :) I am in Asia. Thanks I will try on the nightly. Thanks for all your help. |
Essential work started towards fixing #346
@GregTroar I wanted to check in and see if you've had a chance to validate the changes? Also, while working on V2 OPDS support I believe I successfully implemented the required auth flow to support Cantook: So you should be able to use the app once OPDS V2 support is finished. You can track it separately here: #311 |
Sorry for the delay. on my side it is still not working in Cantook what is the url ? is it /opds/v2/catalog ? I also tried with v1.2 but still seeing the xml code rather than the books. The normal version works with Moonreader and is what i am currently using. |
No worries! It won't work with Cantook, I mentioned another issue in my previous message which will come with Cantook support. I was asking about MoonReader, I'm happy it's working for you |
A 'fix' for Cantook issues is inbound shortly, sometime over the upcoming weekend most likely. The 'fix' was really to support OPDS V2: #367 There are a couple of issues which seem to be on Cantook's side of things, e.g. cover images and labels, but otherwise I tested authentication, feed exploration, and book downloading/reading with no problem 🙂 |
OPDS V2 (experimental) support is now available in the experimental docker image. I'm going to close this ticket out. If any Cantook issues surface, feel free to create a separate, targeted issue to address it 🙂 |
Describe the bug
I have tried Monnreader+ as well as Cantook on Android and I cannot access to the OPDS feed.
On Cantook I keep getting a 401 error (unauthorized), I am using the url https://login:pass@ip:port/opds/v1.2/catalog, tried also without the login and pass in URL and also not working.
For Moonreader+ it just shows the xml file saying that it does not recognize the file so it is like this:
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Expect to have the OPDS menu "keep reading" and so on...
Smartphone (please complete the following information):
The text was updated successfully, but these errors were encountered: