🐛 Fix OPDS path detection regression #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recent change to split the main OPDS router into sub-routers for each supported version caused some issues in the auth middleware. Specifically, the `/opds` prefix was missing which caused the conditional check which allows basic auth for OPDS-specific routes. This is expected behavior with the changes, since accessing the request parts `uri` in an extension is scoped to the router, which after nesting multiple routers under the main opds one means the top-level is v1.2
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #346
The recent change to split the main OPDS router into sub-routers for each supported version caused some issues in the auth middleware. Specifically, the
/opdsprefix was missing which caused the conditional check which allows basic auth for OPDS-specific routes to fail.Accessing the request parts
uriin an extension seems to be scoped to the current router. This means when the auth middleware attempted to extract theuri, it was now relative to the new sub-router (which in this case, would be /v1.2/*). To correct this, I just used theOriginalUriextractor.I also used this as an opportunity to fix some of the session handling logic in the OPDS auth flow