Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⏪ Revert AVIF image support #409

Merged
merged 3 commits into from
Aug 21, 2024
Merged

⏪ Revert AVIF image support #409

merged 3 commits into from
Aug 21, 2024

Conversation

aaronleopold
Copy link
Collaborator

@aaronleopold aaronleopold commented Aug 21, 2024

After some discussions on Discord and debugging avif-related bugs, I am temporarily reverting the avif additions. This isn't a literal revert commit, I've kept in a few bits for easier re-integration later.

It's a bit unfortunate, but I think this decision is for the best until Stump can provide a more batteries-included solution for folks with avif needs. Please reach out in the corresponding GitHub issue (#339) or on Discord if this is something you want to see sooner rather than later!

Over the weekend or next couple of weeks, I will at least try to add back support for avif images outside the context of thumbnail generation (e.g. you have media files which contain avif and want to read them)

After a lot of discussions on Discord and avif-related bugs, I am temporarily reverting the avif additions. This isn't a literal commit revert, I've kept in a few bits for easier re-integration later
@aaronleopold aaronleopold changed the title ⏪ Revert avif support ⏪ Revert AVIF image support Aug 21, 2024
@aaronleopold aaronleopold linked an issue Aug 21, 2024 that may be closed by this pull request
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
core/src/filesystem/common.rs 52.56% <ø> (ø)
core/src/filesystem/content_type.rs 83.43% <ø> (+0.52%) ⬆️
core/src/filesystem/image/generic.rs 98.10% <ø> (-1.53%) ⬇️
core/src/filesystem/image/process.rs 87.09% <ø> (-0.56%) ⬇️
core/src/filesystem/image/webp.rs 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

@aaronleopold aaronleopold merged commit 3ea2804 into develop Aug 21, 2024
8 checks passed
@aaronleopold aaronleopold deleted the al/revert-avif branch August 21, 2024 14:34
@aaronleopold aaronleopold mentioned this pull request Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Unable to run executables due to missing DLL
1 participant