Bump golangci-lint to v1.53.2 #1268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newer versions of depguard, as used in golangci-lint 1.53.0 and later, deny imports by default. As a result, depguard should only be enabled if it's going to be used, which isn't the case currently in Submariner projects. Signed-off-by: Stephen Kitt <[email protected]>
This adds - gosmopolitan - mirror - tagalign - zerologlint These will be enabled as appropriate in later PRs. It also migrates to depguard v2, requiring configuration updates for projects using it. Signed-off-by: Stephen Kitt <[email protected]>
skitt
requested review from
mkolesnik,
Oats87,
sridhargaddam and
tpantelis
as code owners
|
🤖 Created branch: z_pr1268/skitt/golang-ci-lint-1.53.2 |
This sorts the list of enabled linters and removes commented entries for deprecated and obsolete linters. Signed-off-by: Stephen Kitt <[email protected]>
dfarrell07
approved these changes
Jun 15, 2023
|
The admiral linting error is fixed by submariner-io/admiral#657 which can go in after this. |
Jaanki
approved these changes
Jun 19, 2023
tpantelis
approved these changes
Jun 21, 2023
|
🤖 Closed branches: [z_pr1268/skitt/golang-ci-lint-1.53.2] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits for details.
Depends on submariner-io/admiral#656
Depends on submariner-io/cloud-prepare#725
Depends on submariner-io/coastguard#169
Depends on submariner-io/coastguard#170
Depends on submariner-io/coastguard#171
Depends on submariner-io/lighthouse#1278
Depends on submariner-io/subctl#790
Depends on submariner-io/submariner#2547
Depends on submariner-io/submariner#2550
Depends on submariner-io/submariner#2551
Depends on submariner-io/submariner-operator#2684