Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump golangci-lint to v1.53.2 #1268

Merged
merged 5 commits into from
Jun 27, 2023
Merged

Bump golangci-lint to v1.53.2 #1268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5d3da46
Disable depguard
skitt Jun 14, 2023
3184126
Bump golangci-lint to v1.53.2
skitt Jun 14, 2023
a7f2e57
Enable new linters, clean up configuration
skitt Jun 14, 2023
681b1f8
Merge branch 'devel' into golang-ci-lint-1.53.2
Jaanki Jun 19, 2023
55a6645
Merge branch 'devel' into golang-ci-lint-1.53.2
skitt Jun 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,13 +44,13 @@ linters:
- bodyclose
- contextcheck
# - cyclop # This is equivalent to gocyclo
- depguard
# - depguard # depguard now denies by default, it should only be enabled if we actually use it
- dogsled
- dupl
- durationcheck
- errcheck
- errorlint
- errname
- errorlint
- exhaustive
# - exhaustivestruct # Not recommended for general use - meant to be used only for special cases
- exportloopref
Expand All @@ -66,30 +66,29 @@ linters:
- goconst
- gocritic
- gocyclo
- goerr113
- godot
# - godox # Let's not forbid inline TODOs, FIXMEs et al
- goerr113
- gofmt
- gofumpt
- goheader
- goimports
# - golint # Deprecated since v1.41.0
# - gomnd # It doesn't seem useful in general to enforce constants for all numeric values
- gomoddirectives
# - gomodguard # We don't block any modules
# - goprintffuncname # This doesn't seem useful at all
- gosec
- gosimple
- gosmopolitan
- govet
# - ifshort # This is a style preference and doesn't seem compelling
- importas
- ineffassign
# - ireturn # The argument to always "Return Concrete Types" doesn't seem compelling. It is perfectly valid to return
# an interface to avoid exposing the entire underlying struct
# - interfacer # Deprecated since v1.38.0
- lll
- makezero
# - maligned # Deprecated since v1.38.0
- mirror
- misspell
- nakedret
# - nestif # This calculates cognitive complexity but we're doing that elsewhere
Expand All @@ -104,10 +103,10 @@ linters:
- promlinter
- revive
# - rowserrcheck # We don't use SQL
# - scopelint # Deprecated since v1.39.0
# - sqlclosecheck # We don't use SQL
- staticcheck
- stylecheck
- tagalign
# - tagliatelle # Inconsistent with stylecheck and not as good
# - tenv # Not relevant for our Ginkgo UTs
- testpackage
Expand All @@ -122,6 +121,7 @@ linters:
- whitespace
- wrapcheck
- wsl
- zerologlint
issues:
exclude-rules:
# Allow dot-imports for Gomega BDD directives per idiomatic Gomega
Expand Down
2 changes: 1 addition & 1 deletion package/Dockerfile.shipyard-dapper-base
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ RUN dnf -y install --nodocs --setopt=install_weak_deps=False \
find /usr/bin /usr/lib/golang /usr/libexec -type f -executable -newercc /proc -size +1M ! -name hyperkube \( -execdir upx ${UPX_LEVEL} {} \; -o -true \) && \
ln -f /usr/bin/kubectl /usr/bin/hyperkube

ENV LINT_VERSION=v1.52.2 \
ENV LINT_VERSION=v1.53.2 \
HELM_VERSION=v3.11.3 \
KIND_VERSION=v0.18.0 \
BUILDX_VERSION=v0.10.4 \
Expand Down
Loading